Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Routes): Add guildBulkBan() route #909

Merged
merged 1 commit into from Mar 31, 2024
Merged

feat(Routes): Add guildBulkBan() route #909

merged 1 commit into from Mar 31, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2024 •
edited by almeidx
Loading

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@ghost ghost requested review from a team as code owners March 18, 2024 09:40
@ghost ghost requested review from vladfrangu, iCrawl, kyranet and SpaceEEC March 18, 2024 09:40
@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 8:58pm

@vladfrangu
Copy link
Member

Please clone the repo locally and lint your changes! See the https://discord-api-types.dev/docs/contributing_to_discord-api-types guide

@ghost
Copy link
Author

ghost commented Mar 18, 2024

Please clone the repo locally and lint your changes! See the https://discord-api-types.dev/docs/contributing_to_discord-api-types guide

Done

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Mar 18, 2024 •
edited
Loading

Still not linted
Also you should add interfaces for params / result from the endpoint and the error code

@sdanialraza
Copy link
Contributor

Those are in separate PRs I believe: #908 #910

@ghost
Copy link
Author

ghost commented Mar 18, 2024

Still not linted Also you should add interfaces for params / result from the endpoint and the error code

I don't see any issues being reported when I run npm run lint

@ghost ghost mentioned this pull request Mar 19, 2024
Merged
@vladfrangu vladfrangu merged commit 7dcad58 into discordjs:main Mar 31, 2024
6 checks passed
@ghost ghost deleted the patch-2 branch April 7, 2024 14:59
@theKerosen theKerosen mentioned this pull request May 19, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request May 19, 2024
Closed
@ssplatt ssplatt mentioned this pull request May 22, 2024
Closed
@SkyDev125 SkyDev125 mentioned this pull request May 24, 2024
Closed
@theKerosen theKerosen mentioned this pull request Jun 7, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
topic:rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladfrangu @jaw0r3k @sdanialraza @almeidx