refactor(RoleManager): rm redundant check for icon in #edit

iShibi · iShibi · commit cd025db82737 · 2021-09-30T20:27:08.000+05:30
diff --git a/src/managers/RoleManager.js b/src/managers/RoleManager.js
@@ -192,7 +192,7 @@ class RoleManager extends CachedManager {
     }
 
     let icon = data.icon;
-    if (typeof icon !== 'undefined') {
+    if (icon) {
       const guildEmojiURL = this.guild.emojis.resolve(icon)?.url;
       icon = guildEmojiURL ? await DataResolver.resolveImage(guildEmojiURL) : await DataResolver.resolveImage(icon);
     }

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ class RoleManager extends CachedManager {`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`let icon = data.icon;`
`195`		`- if (typeof icon !== 'undefined') {`
	`195`	`+ if (icon) {`
`196`	`196`	`const guildEmojiURL = this.guild.emojis.resolve(icon)?.url;`
`197`	`197`	`icon = guildEmojiURL ? await DataResolver.resolveImage(guildEmojiURL) : await DataResolver.resolveImage(icon);`
`198`	`198`	`}`