Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): update MessageMention's roles on message edit #4016

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix(Message): update MessageMention's roles on message edit #4016

merged 1 commit into from
Apr 3, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Apr 3, 2020

Please describe the changes this PR makes and why it should be merged:

This PR fixes Message#mentions's roles property to not update due to using an incorrect field name; mentions_roles instead of mention_roles.

Fixes #4015.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 9e4c39a into discordjs:master Apr 3, 2020
@SpaceEEC SpaceEEC deleted the fix/message_mentions_roles branch April 11, 2020 07:04
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

newMessage in messageUpdate contains deleted role mentions
2 participants
@SpaceEEC @iCrawl