Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Guild): cache fetched widget data #4760

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Conversation

NotSugden
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR modifies the Guild#fetchWidget function to cache the data received as it is not sent in the initial GUILD_CREATE packets (API Docs ref)

this PR also changes setEmbed and fetchEmbed to instead return the respective widget function,
this was to avoid duplicated code - both methods do technically call a different endpoint but they yield the same result
Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl requested review from vladfrangu and kyranet August 29, 2020 20:33
src/structures/Guild.js Show resolved Hide resolved
src/structures/Guild.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants