fix(Guild): cache fetched widget data #4760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR modifies the
Guild#fetchWidget
function to cache the data received as it is not sent in the initialGUILD_CREATE
packets (API Docs ref)this PR also changes
setEmbed
andfetchEmbed
to instead return the respective widget function,this was to avoid duplicated code - both methods do technically call a different endpoint but they yield the same result
Status
Semantic versioning classification: