Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PackageLock): reinstall GitHub docgen dev dependency #4958

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

MattIPv4
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

GitHub Actions & local installs using npm ci fail currently due to a GitHub ssh dependency in the lock file. Reinstalling the docgen dependency using the http GitHub URl should resolve this.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@MattIPv4
Copy link
Contributor Author

This moves the lockfile back to v1 at the same time -- package.json states Node 12+ is supported, only Node 15+ uses lockfile v2

@iCrawl
Copy link
Member

iCrawl commented Nov 1, 2020

I would still want to use lockfile v2 sometimes soon moving forward, just to keep this on the record. The moment devs move to Node 15/16 they will automatically use npm7.
Node support shouldn't matter to the lockfile itself.

@iCrawl iCrawl merged commit ed8b3cc into discordjs:master Nov 1, 2020
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-lock-file branch December 2, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants