Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Guild): fetch member if already in the guild #4967

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Nov 1, 2020

Please describe the changes this PR makes and why it should be merged:

This PR fixes a bug that caused an internal error to be thrown when trying add a member to a guild using Guild#addMember.
The error was only thrown if the member was already part of the guild, but not in the cache.

This is due to Discord responding with 204 No Content if the user is already a member of the guild. in that case, as stated in their Documentation.

I solved this by checking for this no content response (which is an array or arrabuffer, depending on the environment), and then fetch the member from the guild to keep the documented return value.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@fernandolguevara
Copy link

any update of this?

@kyranet kyranet requested a review from vladfrangu November 21, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants