fix(Guild): fetch member if already in the guild #4967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes a bug that caused an internal error to be thrown when trying add a member to a guild using
Guild#addMember
.The error was only thrown if the member was already part of the guild, but not in the cache.
This is due to Discord responding with
204 No Content if the user is already a member of the guild.
in that case, as stated in their Documentation.I solved this by checking for this no content response (which is an array or arrabuffer, depending on the environment), and then fetch the member from the guild to keep the documented return value.
Status
Semantic versioning classification: