Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing error codes #5008

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Conversation

NotSugden
Copy link
Contributor

@NotSugden NotSugden commented Nov 14, 2020

Please describe the changes this PR makes and why it should be merged:
this PR adds error codes that were missing from APIErrors in the constants

CANNOT_DELETE_COMMUNITY_REQUIRED_CHANNEL sounds a bit too long, so if someone has a better name for that lmk

the store related error codes were missed out on purpose, discord.js doesn't utilize any of that so i don't think it needs to be added

(api errors listed here)

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/util/Constants.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
src/util/Constants.js Outdated Show resolved Hide resolved
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@iCrawl iCrawl merged commit 7faa73a into discordjs:master Nov 20, 2020
@NotSugden NotSugden deleted the add-error-codes branch July 28, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants