feat(typings): explicitly type PremiumTier and Collectors #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to be a duplicate of or superseded by #5447 |
|
should I remove my other changes and only leave the premiumtier change? |
SpaceEEC
approved these changes
Apr 14, 2021
kyranet
approved these changes
Apr 14, 2021
iCrawl
approved these changes
Apr 14, 2021
iCrawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
CollectionFilter is now generic. All collectors are now properly typed. For example the filter for
channel.awaitMessagesis now(arg0: Message) => booleanPremiumTier is now typed explicitly instead of simply as number
Status and versioning classification:
The only case in which these changes are breaking is if the user did something wrong in which case their code would break anyway