Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SysChanFlags): new flag and rename in sync with client #5506

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

As per https://github.com/discordjs/discord-api-types the flag names for system channel flags are inconsistent with the client, this PR aims to streamline this. Additionally, a new Flag for the new "Send helpful tips for server setup" guild setting has been introduced.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@kyranet kyranet requested a review from iCrawl April 9, 2021 08:51
Copy link
Contributor

@advaith1 advaith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs have to be updated too

Copy link
Contributor

@advaith1 advaith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna add the client descriptions to docs but otherwise lgtm

@almostSouji almostSouji force-pushed the feat/syschanflags-new branch from 383bac8 to 95b2980 Compare April 10, 2021 12:20
@almostSouji almostSouji force-pushed the feat/syschanflags-new branch from 95b2980 to d7d7110 Compare April 10, 2021 12:20
@iCrawl iCrawl merged commit fe93a7e into discordjs:master Apr 14, 2021
@almostSouji almostSouji deleted the feat/syschanflags-new branch April 14, 2021 22:37
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants