feat: api v9 and threads #5570

ckohen · 2021-04-30T00:01:22Z

Please describe the changes this PR makes and why it should be merged:
This is a very preliminary attempt at adding threads: discord/discord-api-docs#2855

⚠️ Disclaimer: as the docs are only semi-finalized and still subject to change, this will remain a draft until they are finalized and threads are actually released and can be test. This is primarily to track progress on the implementation and to ensure all efforts to implement threads can be focused in one place.

Notes:

As of now, threads are included in the channel caches for the client and guild alongside in their respective text channels threads cache. This is because threads are channels at heart, and allows access to said thread channels as you would any normal channel.
Although threads are present in the channel cache, there is a separate event structure in the API, and such those events are mirrored as well.
A minor warning about thread channels in the channel cache: usually discord.js expects ALL channels to be cached. With threads, if the client does not have access to the parent channel, then it does not know the thread exists, so the channels can be uncached.

Feel free to make suggestions for major changes in this code, I am open to implementing this any different way.

Status and versioning classification:

This PR changes the library's interface (methods or parameters added)
I know how to update typings and have done so, or typings don't need updating

iCrawl · 2021-04-30T00:09:22Z

Can't wait to see this merged in v15

ckohen · 2021-04-30T00:10:36Z

Lol yeah, looking forward to that

src/client/actions/ChannelCreate.js

ImRodry

Just a few minor things I think should be improved on as well as a few questions

src/managers/ThreadManager.js

src/managers/UserManager.js

src/structures/Message.js

src/structures/ThreadChannel.js

src/managers/ThreadMemberManager.js

src/structures/ThreadChannel.js

vladfrangu · 2021-05-29T13:00:27Z

You wouldn't get this from any other guy, but this needs a rebase <3

src/client/actions/ThreadListSync.js

vladfrangu · 2021-06-08T11:38:59Z

src/client/actions/ThreadListSync.js

+      });
+
+      /**
+       * Emitted whenever the client user gains access to a text or news channel


Description isn't accurate

What isn't accurate about this?

they're not text or news channels, they're thread channels :P

But the event is emitted when you gain access to the parent channel, being a text or news channel, even if there are no threads.

But the event is emitted when you gain access to the parent channel, being a text or news channel, even if there are no threads.

The event is WHAT? So... when you get access to a channel, you now...get..an event...? But bots/users already know about all channels from the moment they connect...

even if there are no threads.

rly? I think every place that sends it is checking if there are threads, how'd you reproduce it!

Hmm, cannot reproduce with no threads anymore. Although, it does seem weird to not sync threads when there were previously threads. E.g. if you have active threads, lose access to a channel, thread is marked archived, gain access to the channel. Since there is no THREAD_DELETE fired here and we obviously don't get THREAD_UPDATE while not having access to the channel, the cache is now out of date and doesn't get updated (in this case, removing the now archived threads

src/client/actions/ThreadListSync.js

src/structures/ThreadChannel.js

src/structures/ThreadMember.js

src/structures/ThreadChannel.js

src/managers/ChannelManager.js

src/structures/ThreadChannel.js

src/util/Constants.js

src/structures/ThreadChannel.js

Co-authored-by: Amish Shah <dev@shah.gg>

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-Authored-By: SynthGhost <60333233+synthghost@users.noreply.github.com>

Co-Authored-By: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com>

Co-authored-by: Elliot <elliot@maisl.fr>

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-Authored-By: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com> Co-Authored-By: Antonio Román <kyradiscord@gmail.com>

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

ckohen · 2021-06-24T08:10:34Z

Rebased and added the new thing from api docs pr

src/managers/ThreadManager.js

ajpalkovic · 2021-06-24T19:49:59Z

Woohoo, congrats!
Thanks y'all :)

itisdoc · 2021-06-29T19:02:10Z

Lets go! Now I dont have to use private channels for my ticketing system

kevinbioj reviewed Apr 30, 2021

View reviewed changes

src/client/actions/ChannelCreate.js Outdated Show resolved Hide resolved

vaporoxx mentioned this pull request May 1, 2021

Add support for API v9 and Threads #5579

Closed

SpaceEEC linked an issue May 1, 2021 that may be closed by this pull request

Add support for API v9 and Threads #5579

Closed

kyranet added reason: API support labels May 7, 2021

ckohen force-pushed the threads branch from 03712e8 to 90a06b9 Compare May 7, 2021 21:07

ImRodry suggested changes May 11, 2021

View reviewed changes

ckohen force-pushed the threads branch from 90a06b9 to 6c85368 Compare May 12, 2021 01:06

GamingGeek reviewed May 12, 2021

View reviewed changes

src/managers/ThreadMemberManager.js Outdated Show resolved Hide resolved

GamingGeek reviewed May 12, 2021

View reviewed changes

src/structures/ThreadChannel.js Outdated Show resolved Hide resolved

GamingGeek reviewed May 12, 2021

View reviewed changes

src/structures/ThreadChannel.js Outdated Show resolved Hide resolved

ckohen force-pushed the threads branch 2 times, most recently from 753301a to 092376f Compare May 26, 2021 02:15

iCrawl requested review from vladfrangu, SpaceEEC and kyranet May 29, 2021 11:29

ckohen force-pushed the threads branch from 092376f to daf99a7 Compare May 30, 2021 01:59

ckohen force-pushed the threads branch from daf99a7 to 291b61c Compare June 8, 2021 03:49

vladfrangu previously requested changes Jun 8, 2021

View reviewed changes

ckohen force-pushed the threads branch from c4394ff to 3e81257 Compare June 10, 2021 10:38

iCrawl requested a review from vladfrangu June 10, 2021 11:31

ajpalkovic reviewed Jun 10, 2021

View reviewed changes

ckohen force-pushed the threads branch from 3e81257 to c096c84 Compare June 10, 2021 23:31

ckohen marked this pull request as ready for review June 10, 2021 23:31

ckohen force-pushed the threads branch from c096c84 to 1f7b295 Compare June 10, 2021 23:33

ckohen and others added 18 commits June 24, 2021 01:09

docs: fix grammar and typos

cc0020f

Co-authored-by: Amish Shah <dev@shah.gg>

docs: clarify ThreadMemberFlags bits

890069c

refactor(ThreadChannel): default boolean params to true

6680ddb

fix: members *will* be an array per docs

26bf230

docs: add comments for threadmember.id being the thread id

e2b86da

docs: fix typo

a498436

Co-authored-by: Amish Shah <dev@shah.gg>

fix: pr comments

e4fbff4

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor(ThreadListSync): early return

dcfeb7b

Co-Authored-By: SynthGhost <60333233+synthghost@users.noreply.github.com>

refactor: use existing methods

ac1f0c4

Co-Authored-By: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com>

types: no quotes for string

3793651

Co-authored-by: Elliot <elliot@maisl.fr>

fix: casing

cc014aa

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor(ThreadManager): make Snowflake regex stricter

582117b

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor: pr comments

62cec51

Co-Authored-By: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com> Co-Authored-By: Antonio Román <kyradiscord@gmail.com>

refactor: address pr comments

04a0dcc

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor: better iteration

9ec3810

refactor: move adding to ThreadMemberManager, rename internals

70f80bb

chore: use values directly in iteration

3bc9b0c

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

feat(ThreadManager): use type in create

5725762

ckohen force-pushed the threads branch from 787e93b to 5725762 Compare June 24, 2021 08:10

NotSugden reviewed Jun 24, 2021

View reviewed changes

src/managers/ThreadManager.js Show resolved Hide resolved

iCrawl merged commit 7346621 into discordjs:master Jun 24, 2021

ckohen deleted the threads branch June 24, 2021 19:53

BannerBomb mentioned this pull request Jun 24, 2021

Fixed typos from commit #5570 #5917

Merged

iCrawl pushed a commit that referenced this pull request Jun 24, 2021

Fixed typos from commit #5570 (#5917)

d984ac9

iCrawl added this to the Version 13 milestone Jun 27, 2021

ckohen mentioned this pull request Jun 29, 2021

chore(Threads): general fixup and catch up on features #5959

Merged

Jiralite mentioned this pull request May 2, 2023

fix(Constants): Ordering and missing information #9500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: api v9 and threads #5570

feat: api v9 and threads #5570

ckohen commented Apr 30, 2021 •

edited

Loading

iCrawl commented Apr 30, 2021 •

edited

Loading

ckohen commented Apr 30, 2021

ImRodry left a comment

vladfrangu commented May 29, 2021

vladfrangu Jun 8, 2021

ckohen Jun 8, 2021

vladfrangu Jun 8, 2021

ckohen Jun 8, 2021

vladfrangu Jun 10, 2021 •

edited

Loading

ajpalkovic Jun 10, 2021

ckohen Jun 10, 2021

ckohen commented Jun 24, 2021

ajpalkovic commented Jun 24, 2021

itisdoc commented Jun 29, 2021

feat: api v9 and threads #5570

feat: api v9 and threads #5570

Conversation

ckohen commented Apr 30, 2021 • edited Loading

iCrawl commented Apr 30, 2021 • edited Loading

ckohen commented Apr 30, 2021

ImRodry left a comment

Choose a reason for hiding this comment

vladfrangu commented May 29, 2021

vladfrangu Jun 8, 2021

Choose a reason for hiding this comment

ckohen Jun 8, 2021

Choose a reason for hiding this comment

vladfrangu Jun 8, 2021

Choose a reason for hiding this comment

ckohen Jun 8, 2021

Choose a reason for hiding this comment

vladfrangu Jun 10, 2021 • edited Loading

Choose a reason for hiding this comment

ajpalkovic Jun 10, 2021

Choose a reason for hiding this comment

ckohen Jun 10, 2021

Choose a reason for hiding this comment

ckohen commented Jun 24, 2021

ajpalkovic commented Jun 24, 2021

itisdoc commented Jun 29, 2021

ckohen commented Apr 30, 2021 •

edited

Loading

iCrawl commented Apr 30, 2021 •

edited

Loading

vladfrangu Jun 10, 2021 •

edited

Loading