fix(GuildMemberManager): allow moving members to any non-text channel

[AndyClausen]

Please describe the changes this PR makes and why it should be merged:

This will allow moving members to channels with type stage. Closes #5673 🙂

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[tipakA]

Technically, this way category channels are going to be an issue, since they return false from isText()
Is this a call for isVoice()? 👀

[AndyClausen]

Technically, this way category channels are going to be an issue, since they return false from isText()
Is this a call for isVoice()? 👀

Touché. I could change this to just add stage to the list of checks, but if an isVoice method is going to be added, I'd much rather wait for that 😅

[PraveshKunwar]

Technically, this way category channels are going to be an issue, since they return false from isText()
Is this a call for isVoice()? 👀

would an isVoice method be needed?

[ThaTiemsz]

Technically, this way category channels are going to be an issue, since they return false from isText()
Is this a call for isVoice()? 👀

Touché. I could change this to just add stage to the list of checks, but if an isVoice method is going to be added, I'd much rather wait for that 😅

Store channels will also be an issue.

[tipakA]

Well, yes, i wasn't really trying to provide an extensive list of every single channel type this check will not work with, but simply give an example of why isText() isn't exactly the way here.

And my mention of isVoice() was made to avoid this issue in future in case discord would make new voice channel type. I'm definitely not saying whether it should be added or not, since it's a overall niche use case.

[ckohen]

Since all applicable voice channels (dm channels technically have voice, but they don't count and not for bots anyways) extend BaseGuildVoiceChannel, and any future channel you could move people in a guild should probably follow suit, you can use instanceof BaseGuildVoiceChannel I think.

[AndyClausen]

I'll try that out tomorrow.

Now that I have you all here, should I rather make a new commit or amend the existing when it's such small changes? I've heard many different opinions from other repos.

[AndyClausen]

Tested with instanceof, seems to work. Rebased and amended my commit.