fix(CommandInteraction): cmds with no options throw error #5734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
cough So, I totally forgot about slash cmds with no options in #5705. The
options
param inCommandInteraction#_createOptionsCollection
would beundefined
for such cmds and thus iterating over it will throw error. This PR fixes the issue by returning an empty collection whenoptions
is undefined. I did think of makingCommandInteraction#options
null at first:but then I saw that before #5705, it was set to an empty array for cmds that have no options, so I went with the empty collection fix.
Status and versioning classification: