revert(BitField): ⏪ Bring back-compatibility after BitField serialization #5910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In #4879, some modifications were made to permissions and bitfield methods.
Especially on the type of bitfields that moves from number to BigInt.
This move has some impact on serialization and deserialization.
Take the example of a simple
JSON.stringify
andJSON.parse
.The method
toJSON()
(provided by BitField class) will be called and the type (BigInt in the case of Permissions) will be transformed into a string:In the past, this type changing was not needed because a number remains a number.
In the actual Bitfield class if you try to pass permissions that went through serialization and deserialization you get the beautiful error
BITFIELD_INVALID
.So a simple role or channel creation bring you to a crash of your action.
This PR is here to provide compatibility between Bigint stringified and BitFields.
Status and versioning classification: