-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InteractionCollector): reworked to be more generic #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Jul 2, 2021
vladfrangu
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than kyra's comments, LGTM
monbrey
commented
Jul 2, 2021
kyranet
approved these changes
Jul 2, 2021
iCrawl
approved these changes
Jul 2, 2021
SpaceEEC
requested changes
Jul 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
SpaceEEC
approved these changes
Jul 3, 2021
This needs a rebase. |
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally pushed a delete to remote on the old PR #5936 so.... yeaaaaaah.
Another half-baked idea that comes out of late night conversations and early morning coding.
This refactors the
MessageComponentInteractionCollector
into a genericInteractionCollector
that can be used to collect any sort of interaction (yes, even Slash Commands).It also removes the need for it to be bound to any particular message or channel, though it still can be should you want to do that. These are still separate options to the filter as it allows the Collector to also listen to the relevant DELETE events and cancel itself accordingly. It will use these based on the most specific option first, so Message > Channel > Guild.
Draft for now - I'd still like reviews and opinions from other people. I intend to add some checking to the constructor to account for options that don't make sense together, e.g. setting a
componentType
option ifinteractionType
is set for slash commands.Status and versioning classification