-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Threads): max autoArchiveDuration option #6304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make a new method in Util to fetch the highest duration available for a guild, but otherwise this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really love to see this filtering get moved to a util function, but LGTM I suppose
Please describe the changes this PR makes and why it should be merged:
This adds a
"MAX"
option toThreadAutoArchiveDuration
that sets a thread's auto-archive duration to the maximum one, based on the guilds boost count.I understand that this is not really needed, so here's a couple of reasons this may or should get rejected:
ThreadAutoArchiveDuration
type tonumber | string
(could be solved by setting all options to string and converting later)Status and versioning classification: