Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError or ValueError when setting non dictlikes on Dict #6

Open
ThomasWaldmann opened this issue Nov 10, 2010 · 1 comment
Open
Labels
bug Something isn't working

Comments

@ThomasWaldmann
Copy link
Member

Original report by Adam Lowry (Bitbucket: robotadam, GitHub: robotadam).


If you instantiate or call set on a Dict element with non-dictlike data, the call will fail. Since we now have .raw to ensure that valid data was passed to it, it seems like this call should behave like List.set, which will ignore return False instead of failing.

I've got a patch + test for this in a fork.

@ThomasWaldmann
Copy link
Member Author

Original comment by Adam Lowry (Bitbucket: robotadam, GitHub: robotadam).


https://bitbucket.org/RobotAdam/flatland-invalid-dict-data

@ThomasWaldmann ThomasWaldmann added major bug Something isn't working and removed major labels Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant