Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version incompatibilities #13

Closed
tvogels opened this issue Dec 12, 2018 · 3 comments
Closed

Version incompatibilities #13

tvogels opened this issue Dec 12, 2018 · 3 comments

Comments

@tvogels
Copy link
Collaborator

tvogels commented Dec 12, 2018

This project requires a fixed version of react and react-dom (of all dependencies, in fact). This leads to warnings when using JERI in a project that features a more recent version of the framework.

[3/4] Linking dependencies...
warning " > jeri@1.1.0" has incorrect peer dependency "react@15.6.1".
warning " > jeri@1.1.0" has incorrect peer dependency "react-dom@15.6.1".
@cbreak-black
Copy link
Contributor

What would be a better solution? I was told that webdevs always fix their dependencies (and even commit thousands of lines worth of npm-shrinkwrap.json and yarn.lock files) because of the fragility of the ecosystem. Can we selectively loosen the requirements or should we just delete the lock files?

@ja-no
Copy link

ja-no commented Dec 14, 2018

Why not simply turning the peer dependencies into dependencies? AFAIK this would bundle the necessary versions with JERI and would not require the developer to handle the peer dependencies. If we do so, we should also edit the examples and remove the explicit loading of react and react-dom from cdnjs.cloudflare.com.

@cbreak-black
Copy link
Contributor

This should be 'fixed' in e5e0c02 and 21ed42a, to be released eventually. The fix is to insist on a newer version.
There seem to be technical reasons to make react and react-dom peer instead of direct dependencies: see this react issue on the topic and this related issue with further explanations in the yarn docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants