-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version incompatibilities #13
Comments
What would be a better solution? I was told that webdevs always fix their dependencies (and even commit thousands of lines worth of npm-shrinkwrap.json and yarn.lock files) because of the fragility of the ecosystem. Can we selectively loosen the requirements or should we just delete the lock files? |
Why not simply turning the peer dependencies into dependencies? AFAIK this would bundle the necessary versions with JERI and would not require the developer to handle the peer dependencies. If we do so, we should also edit the examples and remove the explicit loading of react and react-dom from cdnjs.cloudflare.com. |
This should be 'fixed' in e5e0c02 and 21ed42a, to be released eventually. The fix is to insist on a newer version. |
This project requires a fixed version of react and react-dom (of all dependencies, in fact). This leads to warnings when using JERI in a project that features a more recent version of the framework.
The text was updated successfully, but these errors were encountered: