Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kebab-caseificiation #1539

Closed
Baccata opened this issue May 24, 2024 · 2 comments
Closed

Fix kebab-caseificiation #1539

Baccata opened this issue May 24, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Baccata
Copy link
Contributor

Baccata commented May 24, 2024

See https://github.com/disneystreaming/smithy4s/blame/89e88c972174fa0a3b2853901a52a5a6a4662c6d/modules/decline/src/core/commons.scala#L31

Running this on a string that starts with a lowercase erases the first letter.

@Baccata Baccata added bug Something isn't working good first issue Good for newcomers labels May 24, 2024
@plokhotnyuk
Copy link
Contributor

@Baccata
Copy link
Contributor Author

Baccata commented May 24, 2024

@plokhotnyuk thanks :) tbh it's for a rather un-used CLI-derivation module, performances are not really that critical in this context, but I do appreciate the tip !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants