Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Scaladoc #256

Closed
kubukoz opened this issue Jun 3, 2022 · 6 comments
Closed

Generate Scaladoc #256

kubukoz opened this issue Jun 3, 2022 · 6 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kubukoz
Copy link
Member

kubukoz commented Jun 3, 2022

Originally mentioned in #245 : the @deprecated trait should generate a @deprecated annotation in the Scala code, and the @documentation / @externalDocumentation traits should result in some Scaladoc being generated.

@Baccata
Copy link
Contributor

Baccata commented Jun 12, 2022

I wholefully agree with this

@kubukoz kubukoz self-assigned this Nov 12, 2022
@kubukoz
Copy link
Member Author

kubukoz commented Nov 12, 2022

Started some work on the deprecations part of this.

@Baccata Baccata changed the title Generate Scaladoc / deprecations Generate Scaladoc Jan 11, 2023
@Baccata Baccata added the good first issue Good for newcomers label Jan 11, 2023
@zetashift
Copy link
Contributor

This looks like "fun" good-first-issue. If my noobie questions aren't too much hassle, I'll gladly pick this up.
#599 should provide some tips on how to implement scaladoc in the codegen no?

I believe something like this:

  • Add a case classDocumentation which extends Hint to the IR
  • Then add a way to render scaladocs in Renderer

@daddykotex
Copy link
Contributor

daddykotex commented Jan 13, 2023

This looks like "fun" good-first-issue. If my noobie questions aren't too much hassle, I'll gladly pick this up. #599 should provide some tips on how to implement scaladoc in the codegen no?

I believe something like this:

  • Add a case classDocumentation which extends Hint to the IR
  • Then add a way to render scaladocs in Renderer

I think you got that right! Good luck and don't hesitate to reach out here or on Discord if you need assistance

And thanks, really

@kubukoz
Copy link
Member Author

kubukoz commented Jan 13, 2023

yeah, I think you can draw some inspiration from #599. I left some hints for working on codegen code here, might be useful for a good feedback loop: #496 (comment)

I believe something like this:

that sounds about right

@kubukoz
Copy link
Member Author

kubukoz commented Jan 30, 2023

Mostly closed in #731, with some new tickets spawned to further improve this. Thanks @zetashift!

@kubukoz kubukoz closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants