"thread:ident=some_id" like params, validation failed

[beholderrk]

code like this not working now:

disqus.threads.details(forum=settings.DISQUS_WEBSITE_SHORTNAME, **{'thread:ident': 'some_id'})

because thread:ident don't passed validation in call method of Resource class:

if not kwargs.get(k):
    raise ValueError('Missing required argument: %s' % k)

I replaced this code by:

if k not in [ x.split(':')[0] for x in kwargs.keys() ]:
    raise ValueError('Missing required argument: %s' % k)

https://github.com/disqus/disqus-python/blob/master/disqusapi/__init__.py#L120

[thetylerhayes]

Another way to fix this in the meantime would be to pass :ident in the value instead of the parameter name.

disqus.threads.details(forum=settings.DISQUS_SHORTNAME, **{'thread': 'ident:some_id'})

Or if you were assembling more dynamically:

disqus.threads.details(forum=settings.DISQUS_SHORTNAME, thread='ident:%s' % page.get_our_identifier())

[bartTC]

👍 This was very useful, thanks.

[alanjds]

Before opening another bug, let me ask: where do this thread:ident or ident:some_id is documented?

[dmatt]

@alanjds The threads/details endpoint is documented here https://disqus.com/api/docs/threads/details/

[alanjds]

GET thread:ident=my-identifier&forum=bobross

Oh, right... got it.

I just wish they to had been more explicit than You may pass us the 'ident' or 'link' query types instead of an ID by including 'forum'.

Would had saved me an afternoon.

Thanks @dmatt

[ohadschn]

IMHO the docs are still not clear.

• Nowhere does it explicitly say that ident must correspond to one of the values of identifiers in the https://disqus.com/api/docs/threads/details/ response.
• Clarifying the link: syntax would be great too.
• More generally, adding some sample requests to the API docs would improve things dramatically (other APIs even have interactive query builders and samples).