Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Module '"disqus-react"' has no exported member 'Recommendations' ts(2614) #104

Closed
lucascaton opened this issue Jun 18, 2021 · 3 comments · Fixed by #105
Closed

Comments

@lucascaton
Copy link

lucascaton commented Jun 18, 2021

Recommendations component was introduced in PR #94 (which is great!) but it doesn't seem to have type definitions (like other components do).

To Reproduce

Import the component:

import { Recommendations } from "disqus-react";

And this TypeScript error is displayed:

Module '"disqus-react"' has no exported member 'Recommendations'. ts(2614)

Specifications:

  • OS: macOS Big Sur (11.4)
  • Package version: 1.1.0
  • Node version: 14.17.0
@lucascaton lucascaton changed the title [TypeScript] Module '"disqus-react"' has no exported member 'Recommendations' [TypeScript] Module '"disqus-react"' has no exported member 'Recommendations' ts(2614) Jun 18, 2021
@tterb
Copy link
Contributor

tterb commented Jun 21, 2021

@lucascaton Thanks for the report!
I should be able to get a PR up for this today.

@tterb
Copy link
Contributor

tterb commented Jun 21, 2021

@lucascaton I put up #105 to resolve this issue, but it would be great if you could take a look since I'm admittedly not very familiar with Typescript.

@lucascaton
Copy link
Author

Just tested, all good @tterb. Thanks! 😃

This was referenced Sep 7, 2024
This was referenced Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants