Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in alacritty.yml schema in Alacritty 0.12 #3

Closed
jraregris opened this issue Apr 4, 2023 · 7 comments · Fixed by #4
Closed

Changes in alacritty.yml schema in Alacritty 0.12 #3

jraregris opened this issue Apr 4, 2023 · 7 comments · Fixed by #4

Comments

@jraregris
Copy link

Hi!

Alacritty recently released a new major version with some changes to the alacritty.yml-schema.

It is easy to miss, because I think maybe some the rc-changes was omitted from the main CHANGELOG.md.

https://github.com/alacritty/alacritty/releases/tag/v0.12.0-rc1

I have not read everything thoroughly, but as far as I can tell (from https://github.com/alacritty/alacritty/releases):

  • alt_send_esc is out
  • window.option_as_alt is in
  • window.gtk_theme_variant is out
  • window.resize_increments is in
  • also changes to values in other options

This is intended more as a heads-up than a request or complaint :).
Have a great day!

@KillDozerX2
Copy link
Member

Hey Thanks, I will review the new configuration that they've provided and update schema

@salimhamed
Copy link

salimhamed commented May 2, 2023

Thanks for maintaining this schema, @KillDozerX2! Heads up, I've noticed the missing window.option_as_alt options as well when using this schema for yaml validation.

@KillDozerX2
Copy link
Member

Hey @salimhamed I'm hoping to get to the new schema soon.

@Freed-Wu
Copy link
Contributor

And key_bindings.key can be a number. See alacritty/alacritty#7253 (comment)

cursor.style.vi_mode_style is a legal key. See https://github.com/alacritty/alacritty/releases/download/v0.12.2/alacritty.yml

@tplk
Copy link

tplk commented Dec 18, 2023

I wanted to make a PR with the update, but I noticed that Alacritty is transitioning to TOML for configuration in the next release. Therefore, it seems that this project should be archived in the near future.

  • Configuration file now uses TOML instead of YAML
    Run alacritty migrate to automatically convert all configuration files

https://github.com/alacritty/alacritty/releases/tag/v0.13.0-rc1

@Freed-Wu
Copy link
Contributor

Even if alacritty change yaml to toml, the configuration should also can use json schema. 😄 IMO, why not move this json schema to alacritty in order to make this json schema keep latest with every publishing of new version with alacritty?

@KillDozerX2
Copy link
Member

Apologies in missing out on this, I wasn't aware of the fact that TOML extensions like Event Better TOML also support JSON Schema.
We can now close this issue as well.

Thank you all. @tplk & @jraregris have a look at the TOML extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants