[release/2.7] github.com/miekg/dns is vulnerable to CVE-2017-15133

[brackendawson]

We use a revision of github.com/miekg/dns older than v1.0.0

distribution/vendor.conf

Line 24 in 18230b7

github.com/miekg/dns 271c58e0c14f552178ea321a545ff9af38930f39

pkg:golang/github.com/miekg/dns@0.0.0-20161122061214-271c58e0c14f
1 known vulnerabilities affecting installed version 
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ [CVE-2017-15133]  Uncontrolled Resource Consumption ("Resource Exhaustion")                                                                                                                                                              ┃
┣━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ Description        ┃ A denial of service flaw was found in miekg-dns before 1.0.4. A remote                                                                                                                                              ┃
┃                    ┃ attacker could use carefully timed TCP packets to block the DNS server from                                                                                                                                         ┃
┃                    ┃ accepting new connections.                                                                                                                                                                                          ┃
┣━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ OSS Index ID       ┃ 550f10f6-8f30-4b62-984b-b384d0fd5735                                                                                                                                                                                ┃
┣━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ CVSS Score         ┃ 7.5/10 (High)                                                                                                                                                                                                       ┃
┣━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ CVSS Vector        ┃ CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H                                                                                                                                                                        ┃
┣━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ Link for more info ┃ https://ossindex.sonatype.org/vulnerability/550f10f6-8f30-4b62-984b-b384d0fd5735?component-type=golang&component-name=github.com%2Fmiekg%2Fdns&utm_source=nancy-client&utm_medium=integration&utm_content=0.0.0-dev ┃
┗━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

[thaJeztah]

Looks like a false positive. The CVE is in the DNS server component of miekg/dns (see miekg/dns#631), and the only purpose it's used for in this repository's codebase is for the client parts (in the github.com/xenolf/lego dependency); https://github.com/distribution/distribution/blob/release/2.7/vendor/github.com/xenolf/lego/acme/dns_challenge.go

[brackendawson]

Thanks @thaJeztah, shall we close this issue as consumers of 2.7.2 will be able to link to your statement for their audit stuff?

[thaJeztah]

Perhaps others should double-check, but overall, I think we should be "ok", and no need to update.

I should also link my comment on #3471 (comment), because the same applies to this one.

This dependency is only used by github.com/xenolf/lego, as part of the letsencrypt functionality. I think that functionality was broken on 2.7, so unlikely to be used, but #3134 backports a change to remove it altogether, and replace it with a different implementation.

[milosgajdos]

Given the latest release is v2.8.2 and does not contain this CVE (https://hub.docker.com/_/registry/tags) I believe we should close this issue.

[davidspek]

Agreed.