Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health endpoint improvement #652

Open
davidgengenbach opened this issue Dec 5, 2019 · 3 comments
Open

Health endpoint improvement #652

davidgengenbach opened this issue Dec 5, 2019 · 3 comments

Comments

@davidgengenbach
Copy link

davidgengenbach commented Dec 5, 2019

Is your feature request related to a problem? Please describe.
We had a problem with a killed plugin process (due to OOM) which resulted in non-executing jobs.

Describe the solution you'd like
The health endpoint might be used to check whether all plugin processes are up and running.
In general, more health checks would be helpful, e.g. cluster health?

The endpoint could return a non-200 status code when the instance is not healthy!

@vcastellm
Copy link
Member

Already on the roadmap, will work on this.

@vcastellm
Copy link
Member

@davidgengenbach not really the improvement you mention but I think it's better to fail fast in case of a missing plugin. In case of using as a service the OS supervisor will take care of restarting. This is the case with processor plugins.

@davidgengenbach
Copy link
Author

@Victorcoder Yes, I would agree. Having non-functional (= killed) plugins should really result in a killed main-process.

The linked PR will only kill the main process when a job has been executed unsuccessfully (e.g. by a plugin error) which may be far later than the actual plugin process exiting - a periodic health check could circumvent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants