Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running bin/magento setup:di:compile when installing on 2.3.6 and up #1

Closed
duckchip opened this issue Jan 18, 2021 · 2 comments

Comments

@duckchip
Copy link
Contributor

Description

After upgrading from 2.3.5-p1 to 2.3.6 an undocumented breaking change was introduced to the \Magento\Sales\Model\Order\Pdf\Invoice class. This prevents invoices from being printed if the class has been extended.

Preconditions:

connector v1.0.1
magento 2.3.6 and up

Steps to reproduce

Install the module using composer and run bin/magento setup:di:compile

Expected result

Succesful generation of the interceptors

Actual result

Interception cache generation... 6/9 [==================>---------]  66% 42 secs 232.0 MiBErrors during compilation:
        DistriMedia\Connector\Model\Order\Pdf\Invoice
                Incompatible argument type: Required type: \Magento\Store\Model\App\Emulation. Actual type: \Magento\Framework\Locale\ResolverInterface; File: 
/xxx/vendor/distrimedia/magento2-distrimedia-connector/Model/Order/Pdf/Invoice.php
Total Errors Count: 1
@duckchip
Copy link
Contributor Author

Reference to issue: magento/devdocs#8299

@duckchip
Copy link
Contributor Author

This issue is fixed in a new release: 1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant