Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation and Implementation of the Xwalk (Crosswalk) Feature in AEM #18

Open
samuelecalamita opened this issue Jul 30, 2024 · 5 comments
Assignees

Comments

@samuelecalamita
Copy link
Collaborator

We need to evaluate the Crosswalk (Xwalk) feature and subsequently implement a starter template in our boilerplate for Xwalk projects. see also here

@samuelecalamita
Copy link
Collaborator Author

@samuelecalamita
Copy link
Collaborator Author

The doc based and xwalk boilerplates are quite similar with just some differences in a few lines of code and files (see pull request). We want to extend the cli so that we can generate either a xwalk or a doc based boilerplate.

  • branching from eds-boilerplate-generator
  • rewrite the cli so that it can be possible to generate a xwalk or a doc based project

@samuelecalamita
Copy link
Collaborator Author

hi @mbehzad i've heard that you would like to continue on this topic. If you want have a look in this branch https://github.com/diva-e-aem/eds-boilerplate-generator/tree/18-xwalk-integration and get in touch to me if you need help. Thank you!

@mbehzad
Copy link
Collaborator

mbehzad commented Nov 8, 2024

Hi @samuelecalamita , in doc-based, jest is using jsdom, in the xwalk boilerplate, @happy-dom/jest-environment is used. Does the two boilerplates also need to have different jest setup (+shared part)? Or is currently one jest setup outdated and a single one should work for both? (in the branch is see only jsdom)

@samuelecalamita
Copy link
Collaborator Author

Hi @samuelecalamita , in doc-based, jest is using jsdom, in the xwalk boilerplate, @happy-dom/jest-environment is used. Does the two boilerplates also need to have different jest setup (+shared part)? Or is currently one jest setup outdated and a single one should work for both? (in the branch is see only jsdom)

Hi @mbehzad! One jest setup is definitely outdated. Up to you to choose the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants