Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search users by skills and interests #135

Open
abhivemp opened this issue May 17, 2021 · 5 comments
Open

Search users by skills and interests #135

abhivemp opened this issue May 17, 2021 · 5 comments
Assignees
Labels
component: users issues and pull requests related to the users app enhancement New feature or request good first issue Good for newcomers status: Needs Design Decision The feature still needs work in how it'll be designed

Comments

@abhivemp
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Need an API endpoint on the user component to search through tags and skills.
The models, called TopicTag and SkillTag, stay in the users app

Describe the solution you'd like

Probably the usage of the Q package from django. Would love to discuss better options here.

@abhivemp abhivemp added enhancement New feature or request component: users issues and pull requests related to the users app status: Needs Design Decision The feature still needs work in how it'll be designed labels May 17, 2021
@abhivemp abhivemp assigned abhivemp and unassigned abhivemp May 17, 2021
@abhivemp abhivemp added the good first issue Good for newcomers label May 17, 2021
@TomNewton1
Copy link

TomNewton1 commented May 18, 2021

Hey Abhi,

I am really interested to pick this up as a good first issue. Am I correct in understanding that we need to create a relation between the User model and the TopicTag and SkillTag model? (I looked them up in the img below)

Screenshot 2021-05-18 at 12 43 50

Am I right in thinking that I could do this using a ForeingKey from the TopicTag and SkillTag model to the User model? Or am missing something?

@abhivemp
Copy link
Collaborator Author

Hey @TomNewton1 ! Thanks for picking up this issue. I actually implemented the tags and skills to our models and db yesterday (currently, it's a PR in #134 ). Check that out to see the models implementation.
All you have to do here is write a search function so the endpoint can be used to query through articles, posts, etc.
We actually need to update that diagram. Will work on that today.

@raushanrk5
Copy link

raushanrk5 commented May 18, 2021

Hey @abhivemp, I have also an idea about this issue, like we will show the tags related to article, down its title, and when someone click over any tag, we will show the top articles related to that tag, or if we search for any tags, it will show the same.. I have already done with the implementation of this, but it needs total votes on an article, but that functionality is not done yet, so waiting for that.

@codyseibert
Copy link
Collaborator

codyseibert commented May 19, 2021

@raushanrk5 @abhivemp can we keep this simple for now and just created an endpoint that we can hit such as /api/users?interests=javascript /api/users?skills=javascript,react. If you provide a comma list of tags, it will return users that have BOTH tags in their skill list

@codyseibert codyseibert changed the title Search tags and skills Search users by skills and interests May 19, 2021
@codyseibert
Copy link
Collaborator

@raushanrk5 are you still working on this? have you made any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: users issues and pull requests related to the users app enhancement New feature or request good first issue Good for newcomers status: Needs Design Decision The feature still needs work in how it'll be designed
Projects
None yet
Development

No branches or pull requests

4 participants