Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String models exploit biases in MoleculeNet SMILES dialect to inflate performance #2

Open
cyrusmaher opened this issue Dec 16, 2020 · 0 comments

Comments

@cyrusmaher
Copy link

Following up on a conversation with Meng Liu, I wanted to link this bug. I confirmed it for ClinTox, but it may be present for other datasets:
deepchem/moleculenet#15

One set of solutions would be:

  • Refactoring input parsing code to be shared across models
  • Adding smiles canonicalization to input parsing: from rdkit import Chem; Chem.MolToSmiles(Chem.MolFromSmiles(smiles), canonical=True)
  • Re-running string-based models on all benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant