-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add preview #85
add preview #85
Conversation
@yabe-diverta san I had to update the common default.vue in layouts.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have better to provide gray text instead of back one due to looking invisible a bit so could you provide a special class for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yabe-diverta san
I only know inline styles like this :style="{ color: preview_token ? 'gray' : 'white' }
.
Not very experienced in styles.
And cannot find the class for the "to" link in the scss files.
Can you please suggest where to change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VortexExpansion
I pushed a new commit to set it, could you confirm it?
https://diverta.gyazo.com/16570bad97de39c68b41d21cb8c39140
063aba9
@HisashiHasebe san |
@VortexExpansion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VortexExpansion
I pushed a new commit to set it, could you confirm it?
https://diverta.gyazo.com/16570bad97de39c68b41d21cb8c39140
063aba9
@yabe-diverta san I had a suggestion. While selectively choosing elements and class rendering I also have to take care of whether the user is logged in or not and that is adding to the complexity of conditional checks. Separating the layout altogether solves the problem and elimates the need for extracting the preview token in the layout page. Your thoughts on this ? |
@VortexExpansion |
@yabe-diverta san Further, I think the only things that can be taken out is NavDrawer component something like this <template>
<v-navigation-drawer id="c-navi_side" v-model="model" left fixed dark permanent >
<div class="text-center py-4">
<a href="/">
<img src="~/assets/images/logo.png?width=150" class="c-navi_side-logo" />
</a>
</div>
<v-list>
<v-list-item v-for="(item, i) in items" :key="i" :to="item.to" router class="l-mainmenu_item" :class="{ disabled: item.disabled }">
<v-list-item-action>
<v-icon>{{ item.icon }}</v-icon>
</v-list-item-action>
<v-list-item-title v-text="item.title" />
</v-list-item>
</v-list>
</v-navigation-drawer>
</template>
<script setup>
const model = defineModel();
const props = defineProps({
items: {
type: Array,
required: false,
default: () => []
},
});
</script> and pass props like const navItems = useNavDrawerItems().map(item => ({ ...item, disabled: true })); from I tried but this is failing the drawer interactive button due to v-model pass issue. Even though I integrated it, it doesn't seem to work. Please check if you have time or leave a comment if it is OK up to this point. |
@yabe-diverta san |
@yabe-diverta san |
<v-app class="l-content_wrap"> | ||
<v-navigation-drawer id="c-navi_side" left fixed dark permanent> | ||
<v-app class="l-content_wrap p-dashboard"> | ||
<v-navigation-drawer id="c-navi_side" v-model="drawer" left fixed dark permanent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good solution
@HisashiHasebe san |
Fixes #84
Checkpoints