Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin inputs into iso live registry #190

Closed
blaggacao opened this issue Mar 16, 2021 · 6 comments · Fixed by #191
Closed

pin inputs into iso live registry #190

blaggacao opened this issue Mar 16, 2021 · 6 comments · Fixed by #191
Labels
enhancement New feature or request

Comments

@blaggacao
Copy link
Contributor

Would your feature fix an existing issue?

With #168 , devos live iso gains the ability to enter the devos devshell and install through it on the target machine during bootstrapping.

Still, the target machine is fetching all inputs again.

Describe the solution you'd like

By pinning inputs into the registry:

  • the target will probably use them (if lockfile is not present and declares a different sha)
  • more importantly, the nix store closures will get copied over (I hope I'm right?) and therefore there is no deed to fetch those files

Describe alternatives you've considered

n/a

Additional context

@blaggacao blaggacao added the enhancement New feature or request label Mar 16, 2021
@Pacman99
Copy link
Member

Updated code(realized I wrote it wrong):

nix.registry = mapAttrs (n: v: { flake = ${v}; }) (removeAttrs inputs [ "self" "pkgs" "lib" ]);

@blaggacao

This comment has been minimized.

@Pacman99
Copy link
Member

I would say just wait for that PR to get merged

@blaggacao

This comment has been minimized.

@Pacman99
Copy link
Member

I just think all those things - self, inputs, and hosts - are all pretty related and it makes sense to consolidate them into one PR. The hosts part was already approved so its not much of a blocker. And its really an extension of passing self.

@blaggacao

This comment has been minimized.

bors bot added a commit that referenced this issue Mar 16, 2021
191: iso: copy input closourse into iso to avoide re-download r=blaggacao a=blaggacao

closes #190

Tested on my setup, considerably cuts times and only leaves one (noticable) download.

Co-authored-by: Pacman99 <pachum99@gmail.com>
Co-authored-by: David Arnold <dar@xoe.solutions>
@bors bors bot closed this as completed in 17aee57 Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants