Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: simplify profiles to suites #139

Merged
merged 1 commit into from
Feb 25, 2021
Merged

profiles: simplify profiles to suites #139

merged 1 commit into from
Feb 25, 2021

Conversation

nrdxp
Copy link
Collaborator

@nrdxp nrdxp commented Feb 25, 2021

  • Leave importing to nixpkgs module implentation. Provide a path instead; resolves Profiles imports are brittle, causing failure if imported twice #136.
  • Allow profiles which are not lambdas but simple attribute sets, relaxing the constraints a bit.
  • Update profile README.md
  • defaultImports -> mkProfileAttrs: allow importing subprofiles even if parent directory does not contain a default.nix.

@nrdxp
profiles: simplify profiles to suites
1651913 
* Leave importing to nixpkgs module implentation. Provide a path
  instead; resolves #136.
* Allow profiles which are not lambdas but simple attribute sets,
  relaxing the constraints a bit.
* Update profile README.md
* defaultImports -> mkProfileAttrs: allow importing subprofiles even
  if parent directory does not contain a default.nix.
@nrdxp nrdxp merged commit 314b18e into core Feb 25, 2021
@nrdxp nrdxp mentioned this pull request Feb 25, 2021
Closed
@nrdxp nrdxp deleted the fix-136 branch March 2, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiles imports are brittle, causing failure if imported twice
1 participant
@nrdxp