Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing an interface to nixpkgs.config #237

Closed
fuzzypixelz opened this issue Apr 11, 2021 · 2 comments
Closed

Providing an interface to nixpkgs.config #237

fuzzypixelz opened this issue Apr 11, 2021 · 2 comments
Labels
APIv1 related to 1.0 api stabilization enhancement New feature or request

Comments

@fuzzypixelz
Copy link

fuzzypixelz commented Apr 11, 2021

Your issue may already be reported!
Please search on the issue tracker before creating one.

Would your feature fix an existing issue?

I recently needed to set nixpkgs.config.firefox.enablePlasmaBrowserIntegration = true; and the only way I think that can be done (correct me if I'm wrong) is modifying lib/default.nix, specifically the pkgImport function.

This is also where allowUnfree = true is set (I'm all for sane defaults, but this is very implicit).

Describe the solution you'd like

Maybe collect nixpkgs.config from within the nix` folder? I'm not very familiar with the structure of devos so I can't say many things (again, this might be a non-existent issue and I don't know how it's done)

Describe alternatives you've considered

Additional context

No. I don't think so.

See https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/networking/browsers/firefox/wrapper.nix#L56
for example. There are many useful (and often necessary) options you might want to set.

I for example needed to activation KDE framework integration in firefox, something that nixos modules can't do (a different build is needed).


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@fuzzypixelz fuzzypixelz added the enhancement New feature or request label Apr 11, 2021
@blaggacao
Copy link
Contributor

blaggacao commented Apr 11, 2021

This is also where allowUnfree = true is set (I'm all for sane defaults, but this is very implicit).

This is a huge issue, indeed. It is being worked on in the context of #232, specifically https://github.com/divnix/devos/pull/232/files#diff-b161966f7254af9c9c5382e859495c69622843e4602a6bb4208e08134e660121R138

@blaggacao blaggacao added the APIv1 related to 1.0 api stabilization label Apr 11, 2021
@blaggacao
Copy link
Contributor

This is going to be solved in api-next branch which exposes hostDefaults.config or host.config.

In an effort to clean up issues, I'm going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIv1 related to 1.0 api stabilization enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants