Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Into<BigInt> bound to FieldElementWithInteger::Integer #1071

Open
divergentdave opened this issue Jun 5, 2024 · 0 comments
Open

Add Into<BigInt> bound to FieldElementWithInteger::Integer #1071

divergentdave opened this issue Jun 5, 2024 · 0 comments

Comments

@divergentdave
Copy link
Collaborator

We could clean up our TypeWithNoise implementations if we added a bound to the Integer associated type that provided conversions to and from BigInt. This is needed because we have to take the modulus of the noise to be added in the BigInt domain, before projecting into the field. (This operation is primarily necessary to wrap around negative noise values, but it is moreover necessary so that we correctly implement the DP mechanism on integers, and then project into the field as a post-processing step, preserving the DP guarantees) This trait change should wait for our next batch of breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant