Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload New Version To PyPI #205

Open
alliefitter opened this issue Jun 27, 2018 · 11 comments
Open

Upload New Version To PyPI #205

alliefitter opened this issue Jun 27, 2018 · 11 comments

Comments

@alliefitter
Copy link

alliefitter commented Jun 27, 2018

Ref #63

The current version hosted on PyPi does not have the changes added in fce9e33 which make the module compatible with Python 3. Uploading a new version would be greatly appreciated as this is the only maintained Python APNS library I've found. Thanks! (And thanks for maintaining this repository for so many years!)

@alliefitter
Copy link
Author

Sorry to bump this, but is there any ETA on a PyPi upload?

@Schnodderbalken
Copy link

I would also appreciate the Python 3 compatible version to be published!

@laundry-96
Copy link

Hey, can we get an update to this @djacobs

@djacobs
Copy link
Owner

djacobs commented Jun 25, 2019

I'm open to it, I've not been able to test. The diff appears innocuous. Can folks confirm this is working in production and passes tests?

I agree the right thing to do is to leave old Python behind.

@laundry-96
Copy link

I'm currently in development stages of using this package for a software at work, so no clue what's going to happen. Currently using version 833b00f

@djacobs
Copy link
Owner

djacobs commented Jul 23, 2019

Thanks @laundry-96 - let me know how it goes.

@shiyuchong
Copy link

I currently test it on python 3.6, and test failed

FAIL: testFrame (main.TestAPNs)

Traceback (most recent call last):
File "tests.py", line 193, in testFrame
self.assertTrue(f1 == frame.get_frame() or f2 == frame.get_frame())
AssertionError: False is not true

@djacobs

@shiyuchong
Copy link

and others just pass.

@shiyuchong
Copy link

OK, I have fixed the bug. just change the order in Payload.dict.

@djacobs
Copy link
Owner

djacobs commented Aug 2, 2019

Thanks, please make a pull request.

@shiyuchong
Copy link

shiyuchong commented Aug 2, 2019

@djacobs , Done.
But I recommend you test it again in your own computer. I edit it on github, so there maybe problems like indent. Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants