add oracle to CI #33

Author: bckohan

.github/workflows/test.yml

@@ -145,10 +145,9 @@ jobs:
             django-version: 'Django~=3.2.0'
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -212,10 +211,9 @@ jobs:
           - 3306:3306
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -280,10 +278,9 @@ jobs:
           - 3306:3306
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -302,3 +299,61 @@ jobs:
       - name: Run Full Unit Tests
         run: |
           poetry run pytest --cov-fail-under=95
+
+  oracle:
+    runs-on: ubuntu-latest
+    env:
+      DATABASE: oracle
+    strategy:
+      matrix:
+        python-version: [ '3.7', '3.11']
+        django-version:
+          - 'Django~=3.2.0' # LTS April 2024
+          - 'Django~=4.2.0' # LTS April 2026
+        exclude:
+          - python-version: '3.7'
+            django-version: 'Django~=4.2.0'
+          - python-version: '3.11'
+            django-version: 'Django~=3.2.0'
+
+    services:
+      oracle:
+
+        image: gvenzl/oracle-free:latest
+
+        env:
+          ORACLE_PASSWORD: password
+          ORACLE_DATABASE: test
+
+        # Forward Oracle port
+        ports:
+          - 1521:1521
+
+        # Provide healthcheck script options for startup
+        options: >-
+          --health-cmd healthcheck.sh
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 10
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install Poetry
+        uses: snok/install-poetry@v1
+        with:
+          virtualenvs-create: true
+          virtualenvs-in-project: true
+      - name: Install Dependencies
+        run: |
+          poetry config virtualenvs.in-project true
+          poetry run pip install --upgrade pip
+          poetry install -E all --with oracle
+          poetry run pip install -U "${{ matrix.django-version }}"
+      - name: Run Full Unit Tests
+        run: |
+          poetry run pytest --cov-fail-under=95

README.rst

@@ -221,12 +221,18 @@ Like with Django, Postgres is the preferred database for support. The full
 test suite and static analysis is run against all combinations of currently
 supported versions of Django, Python, and Postgres as well as psycopg3 and
 psycopg2. The other RDBMS supported by Django are also tested including SQLite,
-MySQL, MariaDB and Oracle. For these RDBMS, tests are run against the minimum
-and maximum supported version combinations to maximize coverage breadth. For
-example, as of the release of Django 4.2.0 the following combinations of
-Python, Django and MySQL are tested:
+MySQL, MariaDB and Oracle. For these RDBMS (with the exception of Oracle),
+tests are run against the minimum and maximum supported version combinations to
+maximize coverage breadth. For example, as of the release of Django 4.2.0 the
+following combinations of Python, Django and MySQL are tested:
 
 .. code::
 
     Python 3.7, Django 3.2, MySQL 5.7, mysqlclient 1.4.0
     Python 3.11, Django 4.2, MySQL 8.0, mysqlclient 2.1.1
+
+.. note::
+
+    For Oracle, only the latest version of the free database is tested against
+    the minimum and maximum supported versions of Python, Django and the
+    cx-Oracle driver.

django_enum/tests/settings.py

@@ -56,10 +56,10 @@
         'default': {
             'ENGINE': 'django.db.backends.oracle',
             'NAME': os.environ.get('ORACLE_DATABASE', 'test'),
-            'USER': os.environ.get('ORACLE_USER', 'root'),
-            'PASSWORD': os.environ.get('ORACLE_PASSWORD', ''),
-            'HOST': os.environ.get('ORACLE_HOST', ''),
-            'PORT': os.environ.get('ORACLE_PORT', ''),
+            'USER': os.environ.get('ORACLE_USER', 'system'),
+            'PASSWORD': os.environ.get('ORACLE_PASSWORD', 'password'),
+            'HOST': os.environ.get('ORACLE_HOST', 'localhost'),
+            'PORT': os.environ.get('ORACLE_PORT', 1521),
         }
     }
 

pyproject.toml

@@ -69,12 +69,6 @@ importlib-metadata = [
     { version = ">=5.0", markers = "python_version > '3.7'" },
 ]
 
-[tool.poetry.group.psycopg2]
-optional = true
-
-[tool.poetry.group.psycopg3]
-optional = true
-
 [tool.poetry.group.psycopg2.dependencies]
 psycopg2 = "^2.5.4"
 
@@ -84,6 +78,9 @@ psycopg = "^3.1.8"
 [tool.poetry.group.mysql.dependencies]
 mysqlclient = ">=1.4.0"
 
+[tool.poetry.group.oracle.dependencies]
+cx-Oracle = '>=6.0.0'
+
 [build-system]
 requires = ["poetry-core>=1.0.0"]
 build-backend = "poetry.core.masonry.api"