Skip to content

Add support for python 3.7 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simkimsia opened this issue Oct 15, 2018 · 2 comments
Closed

Add support for python 3.7 #495

simkimsia opened this issue Oct 15, 2018 · 2 comments

Comments

@simkimsia
Copy link

simkimsia commented Oct 15, 2018

I like to contribute with a PR regarding adding python 3.7

I read https://github.com/django-json-api/django-rest-framework-json-api/blob/master/docs/CONTRIBUTING.md

and my changes are in my fork.

simkimsia@c23c318

Can I proceed?

@sliverc
Copy link
Member

sliverc commented Oct 15, 2018

Current DRF version doesn't officially support Python 3.7 as of issue #486.

So for official Python 3.7 support DRF 3.9 needs to be released. Also only Django 2.0+ supports Python 3.7. Django Filters as of version 2.0

However feel free to open a PR where update of DRF and Python is prepared and can be merged once it is released.

@simkimsia
Copy link
Author

@sliverc from what I understand, I think master branch of DRF already has 3.7 python. Not sure if this means it's out in 3.8.2 or not.

See encode/django-rest-framework@7f77340

But I did realise that Django 1.11 is not supporting python 3.7 django/django#10371, so i guess this is a moot point. I will close this ticket then.

Personally I am only interested to use only LTS versions of Django to reduce complexity. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants