Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameters passed to Applicator with Oscar 1.1 #104

Closed
sasha0 opened this issue Jun 29, 2015 · 3 comments
Closed

Wrong parameters passed to Applicator with Oscar 1.1 #104

sasha0 opened this issue Jun 29, 2015 · 3 comments

Comments

@sasha0
Copy link
Member

sasha0 commented Jun 29, 2015

In the recent Oscar version 1.1, Applicator expects next parameters - basket, user, request:

class Applicator(object):

    def apply(self, basket, user=None, request=None):

Per https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/offer/applicator.py#L19.
However, Applicator in django-oscar-paypal sends:

# Re-apply any offers
        Applicator().apply(basket, self.request.user, self.request)

Per https://github.com/sasha0/django-oscar-paypal/blob/master/paypal/express/views.py#L228

@fjsj
Copy link

fjsj commented Jul 27, 2015

bump!

@feado
Copy link

feado commented Jul 28, 2015

thanks! it works!

@maiksprenger
Copy link
Member

Merging #101 should've fixed this. Thanks for the good issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants