Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video component causes inaccurate progress bar #50

Open
tassaron opened this issue Jul 25, 2017 · 4 comments
Open

Video component causes inaccurate progress bar #50

tassaron opened this issue Jul 25, 2017 · 4 comments
Labels

Comments

@tassaron
Copy link
Collaborator

tassaron commented Jul 25, 2017

There are a few bugs with the video component that I'm unsure how to fix:

  • It causes the progress bar to be inaccurate (reaches 99% when it should be around 80%).
  • It eats stdout
@dv-anomaly
Copy link
Collaborator

Do you know if the bug is present all the way back to the initial implementation?

@tassaron
Copy link
Collaborator Author

tassaron commented Jul 25, 2017

Just tested and both bugs are present in the initial implementation (7946e98).

@dv-anomaly
Copy link
Collaborator

Like I said previously I don't have a whole lot of free time through the rest of the month. I will see what I can do next week if this is still in open Bug. I don't see anything obvious at the moment.

@tassaron
Copy link
Collaborator Author

I fixed stdout being eaten, using this from SO.

The progress bar issue continues to elude me. The encoding progress outputted by FFmpeg is accurate, so it's possible the best fix would be to change how we measure the Qt progressbar -- we should use the time output from ffmpeg compared to the expected audio duration, instead of the current method of using the audio frame number. This would make the progress bar accurately represent the progress of ffmpeg instead of the progress of input #0 (the pipe to ffmpeg)

@tassaron tassaron changed the title Video component bugs Video component causes inaccurate progress bar Jul 29, 2017
@tassaron tassaron removed the newgui label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants