Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "alt text" option for banner image #289

Closed
Tracked by #285
djplaner opened this issue Aug 31, 2023 · 1 comment · Fixed by #290
Closed
Tracked by #285

Add "alt text" option for banner image #289

djplaner opened this issue Aug 31, 2023 · 1 comment · Fixed by #290
Labels
enhancement New feature or request

Comments

@djplaner
Copy link
Owner

Module banner images currently have a hard-coded (largely useless) alt text.

As suggested add a text area to allow entry of alt text for banner images.
@djplaner djplaner added the enhancement New feature or request label Aug 31, 2023
@djplaner djplaner mentioned this issue Sep 1, 2023
Open
38 tasks
@djplaner
Copy link
Owner Author

djplaner commented Sep 1, 2023 •
edited
Loading

Design

Banner image component - add Alt Text element

  • title
  • help link
  • help page
  • text box

Component should also

  • add an empty altText value if one not there
  • keep the alt text free of any and all HTML - use sanitize-html

Representations should use the alt text

  • Griffith Cards
  • Horizontal Cards

@djplaner djplaner linked a pull request Sep 1, 2023 that will close this issue
Implements #285 - alt text to banner images #290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements #285 - alt text to banner images djplaner/canvas-collections
1 participant
@djplaner