-
Notifications
You must be signed in to change notification settings - Fork 3
/
CHANGELOG
1609 lines (1167 loc) · 64.7 KB
/
CHANGELOG
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
*** When upgrading, don't forget to: "cd bin ; ./install.pl" ***
*** Also, it is _highly_ advisable to backup your data before upgrading ***
Version x.x.x
* Add '-n' option to cvs commands, so write access isnt needed to local cvs repos
Version 1.9.11
* Handle Subversion diffs which contain directory copies.
* Fixed issue where Perforce diffs created by just specifying a single tag
would not work.
* Added support for JIRA as an integrated bug-tracker.
Version 1.9.10
* Implemented "log out" action.
* Implemented another corner case with Subversion diffs for handling
empty file entries.
* Fixed issue where duplicate bug IDs specified on topic creation would
prevent the topic from being created.
* Added new configuration option in codestriker.conf for setting the
List-Id header for all emails sent, to assist in filtering,
particularly for gmail. Also added -i parameter to
commit-email-codestriker.pl script to specify the List-Id header
value to use.
* Support for integration with Mantis bug tracking system. Code was
implemented by Gustavo Silva <gramirez@dextratech.com>,
<silvagustavo@users.sourceforge.net> with support from Dextra
Technologies <http://www.dextratech.com>.
* Support for git repositories from Jeffrey Middleton
<jefromi@gmail.com>.
* Fixed "Parallel View" links for ClearCase repositories, from
Thomas Yan <yantao@neusoft.com>.
* Make the message ID in Codestriker emails RFC 2822 compliant.
* Changed usage of email References and In-Reply-To headers so that
email threading will occur at a comment/issue level rather than a
topic level. This should allow for better management of outstanding
issues in email clients such as gmail.
* Implementation of email gateway in bin/codestriker-email-gateway.pl,
which allows for comments to be added to a topic by simply replying
to an email.
* Added support for creating Perforce topics given the path (module_name),
and either two labels or changelists for the start/end tag fields,
from Arun Jose <josea111@users.sourceforge.net>.
* Added support for creating ClearCase Dynamic topics by specifying
a filename in the module field, and either a single version number
in either the start or end tag fields, or specifying two versions
using both fields, from
Lakshmivaragan <lakshmivaragan@users.sourceforge.net>.
Version 1.9.9
* Removed incompatible setting from MySQL database driver, which was
preventing it from working with MySQL 5.1 or later.
* Fixed regression where selecting state "All" from the search topics
screen would only return "Open" topics.
Version 1.9.8
* Fixed issue where using Internet Explorer with a Codestriker
deployment with authentication enabled would prevent new comments
from being added.
Version 1.9.7
* Introduced basic user authentication / authorisation into the
system. If the $admin_users configuration variable is specified
in codestriker.conf, this contains a list of "admin" users.
If defined, admin users are the only ones who can
create/edit/delete projects.
* Created another Subversion post-commit script which is an extension
of the standard commit-email.pl script which ships with Subversion.
The email sent also includes an additional line, which is the URL to
the auto-created topic.
* Updated install.pl so that it can be executed from any directory, not
just bin.
* Creating Perforce topics directly from already committed files in the
depot did not work if the depot was on a different machine to the
web-server. This has now been fixed.
* Fixed an issue where some Perforce describe diffs were not being
parsed correctly as reported by shambhu.1980@gmail.com. This has
now been fixed.
* Added a drop-down on the topic create page where the initial topic
state can be set. By default, this is set to "Open", however in
situations where a review has already been performed but needs to
be recorded, or a topic is automatically created from a post-commit
script from an SCM, sometimes another initial state is desirable.
* Updated install.pl to support a separate Apache virtual host per
Codestriker project as suggested by dmulter@users.sourceforge.net.
Manual has been updated with the appropriate instructions.
* Help popup text windows on the create topic and search screens
disappear automatically when the cursor is moved off the (?) link.
* Fixed a bug where Subversion diffs with binary files that contained
property changes were not handled correctly.
* Make $file_viewer more flexible so it can handle file mapping URLs
which have CGI parameters. Submitted by vadz@users.sourceforge.net.
* Scmbug integration now works correctly when there are multiple
commits to the same file under the one Bug ID. Fixed by
rob_webset@users.sourceforge.net.
* ScmBug integration now works correctly when deleted files are
present in a Subversion changeset.
* Added "Diff" link for each comment on the list comments page so that for
those reviews which aren't linked to an SCM, it is still possible
to quickly link back to the coloured topic text.
* Fixed the rendering of non-latin characters when syntax highlighting
is enabled.
Version 1.9.6
* Ability to create Codestriker topics automatically from a Subversion
commit, via the bin/subversion-post-commit.pl script. Once the
appropriate configuration is set at the start of the file, simply
add it to your Subversion repos/hooks/post-commit file as the
following:
/path/to/codestriker/bin/subversion-post-commit.pl "$REPOS" "$REV"
* "Default to head" option for CVS topic creation was not used when
selected, but when it was unselected. This has now been fixed.
Spotted by mnk26@users.sourceforge.net.
* Fix for "v-string in use/require non-portable" warning when using
Perl 5.10 from rob_webset@users.sourceforge.net.
* Deleting a topic connected with a TestDirector bug has been fixed
by rob_webset@users.sourceforge.net.
* Creation of Subversion topics which use a file for the module field
in the create topic screen may not work correctly for some versions
of Subversion. This has now been fixed by
rob_webset@users.sourceforge.net.
* Make sure XML representation of a topic has its data properly escaped.
Fixed by rob_webset@users.sourceforge.net.
* Ability to parse git patches correctly.
* Ability to parse hg diffs (Mercurial SCM) correctly.
* Better detection of filename extensions for highlighting. This
previously caused issues for temporary directories which contained
a period, but the filename itself didn't. Reported by
rob_webset@users.sourceforge.net.
* Scmbug integration now works correctly if multiple bug IDs are
specified is the create topic screen. Fixed by
rob_webset@users.sourceforge.net.
* Fixed the parsing of Subversion diffs which contained modifications
within property sets. Also fixed case where file in diff is empty.
Reported by clechasseur@users.sourceforge.net.
* Show total added/removed line count after table of contents on view
topic screen. Also show same line counts on create topic email.
* Make the topic title in the edit comment page link directly to the
code location being commented on rather than just the top of the
view topic page.
* Use pegged revisions instead of operative revisions when retrieving
files from Subversion to handle situations where files have been moved
within the repository since the review was created. Fixed by
clechasseur@users.sourceforge.net.
* In the create topic email, show the URL to the associated bug records
if $bugtracker is defined in codestriker.conf rather than just the bug
IDs.
* Allow the Parallel links to work for new files and display them
appropriately.
Version 1.9.5
* Syntax highlighting is now supported using the highlight package from
http://www.andre-simon.de/. Check the codestriker.conf file for
configuration. Many thanks to Nikita V. Borodikhin
<eliterr@users.sourceforge.net> for all his assistance in implementing
this feature.
* Allow the ability to specify just a filename (for the module field)
and a revision number (for the start or end tag) to create a review
for a specific version of a file in a subversion repository.
* Fixed database code which was preventing user metrics being updated
under SQL Server.
* Make sure the email subject field properly encodes underscores and
question marks. Submitted by jon787@users.sourceforge.net.
* Only require Authen::SASL as a pre-requisite if SMTP authentication
is needed. For some deployments, installing Authen::SASL can be
inconvenient.
* Support for TestDirector as a supported bug tracking system.
Submitted by rob_webset@users.sourceforge.net.
* Support for creating reviews by just entering the bug IDs, and
retrieving the data from Scmbug.
Submitted by rob_webset@users.sourceforge.net.
* Make sure if an invalid CGI parameter value is specified that its
value is encoded when displaying the generic error page. Reported
by amalakar@users.sourceforge.net.
* Make sure very long filenames don't move the diff display far to the
right of the view topic page. Fix suggested by
rob_webset@users.sourceforge.net.
* The edit comment page has been updated so that the topic name is
linked back to the associated view topic page.
* Added support for LXR 0.9.5, which renamed the database tables to
contain an lxr_ prefix by default. Support for older LXR databases
will still work by default. LXR entities are now rendered in black text,
the same as program code, but an underline is shown when hovered over.
* Updated the Subversion diff parser so that it correctly identifies new
files, rather than treating them as modified files.
* Removed the "View with minimal screen width" / "View with minimal
link break" options from the view topic screen. If the browser window
is not wide enough, a horizontal scrollbar will appear.
* Provided the ability to create topics for a specific changeset from
a Perforce repository, from Alis McCutcheon <amccutcheon@nxpna.com>.
For example, //depot/src/tools/unittests/python/ can be set
as the module name, and 12736 (the changeset number) can be set
in either the start or end tag field.
* Updated the Codestriker CSS file significantly based on the work by
Kannan Goundan <cakoose@users.sourceforge.net> and Daniel Noll.
Also changed the appearance of the application to give it a more
modern appearance.
* Can now comment on any line of any file in the review, not just those
that are a part of the diff file.
* Introduced new configuration variable $sort_diffs_by_filename in
codestriker.conf which indicates whether the diff chunks inside a
topic should be ordered by filename. Apparently Subversion can
produce diff topics in some circumstances in arbitrary order,
where using this setting would make sense. Default is for this
setting to be enabled.
Version 1.9.4
* Emit a javascript warning if the external javascript files could
not be loaded. This usually occurs due to apache misconfiguration.
* Allow subversion repositories that communicate using the Subversion
protocol to be specified in @valid_repositories as
'svn://my.subversion.server/repos/product/trunk' rather than
'svn:svn://my.subversion.server/repos/product/trunk'.
* Support subversion diff files which contain "Copied:" entries.
* Improved patch file parsing for handling binary file changes.
* Ensure emails sent contain the header "MIME-Version: 1.0" for
RFC2045 conformance. Submitted by Vadim Zeitlin
<vadz@users.sourceforge.net>.
* CSS cleanups from Kannan Goundan <cakoose@users.sourceforge.net>.
* Bottom coloured row on topic list screen didn't extend across full
width of browser window if bug-tracking or custom comment metrics
were defined. This has now been fixed.
* Place a clear divider between comment blocks on the view topic
comments screen, as suggested by Nikita V. Borodikhin
<eliterr@users.sourceforge.net> to minimise confusion.
* The topic comments tab count would incorrectly display the number
of comment threads rather than the number of comments, when viewing
the topic text. This has now been fixed.
* Handle Subversion files which contain @ in the filename.
* Codestriker now behaves correctly under mod_perl when retrieving
data externally from an SCM system, such as when the Parallel link
is clicked, or when a topic is created directly from the SCM.
* Creating Subversion topics directly from the SCM now works correctly
in non-English locales.
* When calculating metrics, make sure email addresses are handled in
a case-insensitive manner. Also remove trailing/leading whitespace
from the addresses.
* Handle topic text that starts with the UTF-8 BOM.
* Workaround for invalid diff files generated by Subversion in a Chinese
locale. See http://marc.info/?l=subversion-users&m=118725115412403&w=3
for more information.
* Handle the different text types that may be present in a Perforce diff.
Submitted by Russell Cattelan <cattelan@thebarn.com>.
* Defined the "noconnection" option for $bug_db in codestriker.conf
so that it is possible to define what bug IDs are associated with
a topic, without updating an actual bug database when the topic
is created/closed. If $bugtracker is defined in codestriker.conf,
then links will be created on the topic properties screen to the
associated bug records. Submitted by Russell Cattelan
<cattelan@thebarn.com>.
* Handle ClearCase diffs which contain "Directories are identical"
lines in them. Submitted by Steve Kinsman
<skinsman@users.sourceforge.net>.
* Support for using the ClearCase dynamic view under Windows.
Submitted by Steve Kinsman <skinsman@users.sourceforge.net>.
Version 1.9.3
* The project list screen now displays for each project, the total
number of open topics, and the total number of topics. Clicking on
the count will go to the topic list screen with the relevant topics
displayed.
* Modified the VSS repository handler so that topics can be created
by either entering in labels or version numbers in the start and
end tag fields when creating a topic. Previously, only labels
were supported.
* The uri filter in the Template Toolkit changed its behaviour in 2.16,
which was responsible for generating invalid links. This has now
been fixed.
* Better handling of Subversion diffs which were generated on
non-English systems.
Version 1.9.2
* Codestriker now works with UTF-8 text, to support unicode character
input for topic titles, descriptions, comment text, and project
names and descriptions. This required making Perl 5.8 as a
pre-requisite, as Perl 5.6 doesn't cut the mustard for unicode
processing.
* Created a new optional configuration parameter $repository_name_map
in codestriker.conf. This allows for a user-defined repository name
to be displayed in the codestriker UI, rather than the full
repository URL. This can be useful for hiding potentially sensitive
username/password information that might be a part of the repository
URL. See the codestriker.conf file for more information.
Submitted by Edwin Fine <edwin.m.fine@verizon.com>.
* New repository module for linking to ClearCase dynamic views. See
the configuration file and/or manual for example configurations.
Submitted by Avinandan Sengupta <avinandan.sengupta@gmail.com>.
* Modified the way Perforce retrieves files from the depot, as servers
set with a security level of 2 or above were not receiving password
information. This has been addressed by modifying the command line
to explictly pass in the password rather than the client workspace
name, which is ignored for these security levels. The repository
configuration for Perforce has also been changed to use the password
in place of the client workspace name. Perforce users should update
their configuration files appropriately. Submitted by
J Dickon Glanville <jdglanville@users.sourceforge.net>.
* Update CVS diff parser to handle rdiffs which have new/removed files
in them.
* Creating a topic with an invalid bug ID is now shown as an error to
the user on the create topic screen.
* If there was an error creating a topic, the selected project name
was not retained when the create topic screen was redisplayed. This
has now been fixed.
Submitted by Edwin Fine <edwin.m.fine@verizon.com>.
* If there is a problem when a comment is created, the error message
will correctly display in the AJAX'ed window. An example here is if
$mailhost is incorrectly configured.
* If there is an email problem while creating a topic, the error
message is now correctly displayed to the end-user.
* Fixed problem with Subversion repositories on Win32, where
Codestriker was unable to launch the svn program.
* Comments containing '+' characters were changed into ' ' characters
when posted via AJAX. Other potentially damaging characters are now
escaped.
* Comments with '\' characters are now displayed correctly in all
cases within the tooltip window.
* Temporary files were not being deleted within the
CodestrikerClient.pm module (used for auto-creation of topics on CVS
commits). Reported by Martin Apel <Martin.Apel@softlab.de>.
* Added support for parsing diffs generated using Subversion's svnlook
program.
* Matching of CVS repository paths when parsing topic text is now
case insensitive to account for the different casing returned by the
Window clients: Cygwin and CvsNT.
* Defining new entries in $comment_state_metrics in codestriker.conf
could not be used for existing topics. This has now been fixed.
* Support for sending email via SMTP authentication, via the optional
$mailuser and $mailpasswd configuration parameters in
codestriker.conf. Contributed by "Hertz Wang" <wanghz@neusoft.com>.
* The ClearCase Snapshot repository was not using the $tmpdir setting
in codestriker.conf if it was set when creating temporary files.
This has now been fixed.
Contributed by "John Farrelly (AT/LMI)" <john.farrelly@ericsson.com>.
* Make sure the diffs in the topic are presented in a sorted order by
filename. Some SCMs create topic texts in a "semi-sorted" order,
such as Subversion.
Contributed by "Vladimir Vysotsky" <vvysotsky@avistar.com>.
* Closed topics could still have comments added to them, by hovering
over an existing comment in the topic text view, and then clicking
the "Add Comment" link in the tooltip window. This link has now
been removed if the topic is closed.
Contributed by ed.torbett@simulation-systems.co.uk.
* Improved memory usage when integrated with very large LXR databases.
Contributed by Patrick Diamond <patrick_diamond@mailc.net>.
* Newer versions of the Subversion client (1.3.2) were returning
warning text that was not parsed correctly. This has now been
fixed. Contributed by Vladimir Sizikov <vsizikov@gmail.com>.
* Make sure the generated Template Toolkit files are stored in
the web server's temporary directory, or $Codestriker::tmpdir if
that is defined. Previously, the temporary files were being stored
in sub-directories of cgi-bin.
Version 1.9.1
* Correct problem introduced in 1.9.0 release where the email address
field in the add comment tooltip was not being stored correctly in
the Codestriker cookie. For reviewers who have never created a
Codestriker topic, the email field not remember the previous value.
This has now been corrected.
* When adding a comment via a link from an email, the confirmation
screen now contains links to the topic text and topic comments, for
convenience.
Version 1.9.0
* Now using overlib javascript library
(http://www.bosrup.com/web/overlib) for formatted "tooltips". When
the mouse hovers over a line where a comment has been made, a
formatted "tooltip" window appears, which contains the comment text
formatted appropriately, with author and date header information
bolded. The tooltip is not removed until the mouse is moved off the
line. Help text on the create topic and search screens have been
modified to use this tooltip library as well as opposed to
javascript alert windows.
* Comments are now added view an overlib tooltip window, rather than
using a separate browser window. This speeds up the reviewing
process and keeps the reviewer focussed on a single browser window.
* It is now possible to create a comment associated with a specific
file, or the topic itself, rather than being associated with a
specific line. This allows reviewers to create file-level or
topic-level comments.
* There are patches available for Bugzilla 2.16 and Bugzilla 2.18 in
the bin subdirectory, where the view bug screen is modified to
include the "Create a New Codestriker Topic" and "View All" links
directly under the "Create a New Attachment" and "View All" links.
When a new topic is created via this link, the topic title will be
set initially to the bug title, and the bug id field will be set to
the id of the bug record. Before applying the patch, the
codestriker_url variable must be set to the URL of your Codestriker
deployment.
* Extra options are now available in the codestriker.conf file in
regards to when emails are sent out. It is now possible to control
whether emails are sent to the topic author and/or the comment
author when new comments are created. Also, there is an option
which determines if all reviewers are notified if the topic's state
is changed. This is all controlled by the $email_send_options
configuration item. From Jason Remillard.
* Added RSS support, so that the topic list screen now has an
equivalent RSS view. From Jason Remillard.
* Optimised database connection code, from Jason Remillard.
* Added a "add other reviewers" link next to the Cc: field in the "add
comment" screen. This allows the comment author to easily Cc all
the other reviewers of the topic, for important comments that needs
to be sent to all reviewers.
* When creating new topics linked to Bugzilla, also include the topic
description field in the Bugzilla comment.
* Searching on the bugid and cc fields was not working correctly.
This has now been fixed.
* On UNIX platforms, missing modules can be fetched and installed
automatically using the CPAN module, if required.
* Subversion 1.1 has changed it diff format slightly. Parser as been
updated, as reported by Martin Apel <Martin.Apel@softlab.de>.
* Added integration support for Flyspray bug-tracking system. From
Martin Apel.
* Fixed text message written to bug-tracking system where the topic
author was used instead of the actual user, when the topic state was
changed. Found by Jason Remilliard.
* Make sure for Win32 deployments, that the PATH environment
variable is not zapped. This created issues when launching external
programs, such as an SCM program. Since taint-mode is broken under
Win32, this isn't an issue. Found by Michael R. Brumm
<michaelbrumm@users.sourceforge.net>.
* Fixed message "Character in 'c' format wrapped in pack at
... Response.pm", as reported by an anonymous user.
* 'Readonly' topic states are now specified in codestriker.conf. For
installations that add their own topic states, this allows them to
have more than one state in which topics can be edited.
From Dan Prince <dan.prince@alumni.carleton.edu>.
* Subversion topic creation fixes from Michael R. Brumm
<michaelbrumm@users.sourceforge.net>. If module refers to file,
path workaround duplicates the file's name at the end of the file
path in the filename field. Starting and ending slash not removed
from module name during getDiff.
* Modified the Perforce parser to handle file-types that return
"xbinary". Also handled Perforce diffs which contain unidiff style
'---' and '+++' header lines. From Hope Duryea <hope_duryea@yahoo.com>.
* Filenames ending in ++, for example, filename.c++ could not be
loaded into the system, due to a bug introduced in 1.8.5.
* Added $svn configuration variable to codestriker.conf, so that the
path to the subversion executable can be specified, which is often a
requirement for Win32 systems.
Version 1.8.5
* Complete support for VSS repositories. Topics linked to a VSS
repository can now be created by either specifying labels with the
VSS directory of interest for code already committed in the
repository, or pre-commit reviews can be done by generating diff
text with the ssdiff.pl script in the Codestriker bin directory.
* Modified log_accum.pl so that deleted files are also included in the
topic.
* On the topic list screen, there is a new button "Obsolete Topics",
which allows you to create a new topic which superseeds the selected
topics. The obsoleted topics will be changed to state "Obsoleted"
and will become read-only. Note the @topic_states configuration
variable in codestriker.conf needs to be modified to include the new
'Obsoleted' state to enable this. The view topic screens have been
modified to include links if the topic being viewed has been
obsoleted or superseeds other topics. A single topic can be
obsoleted from the view topic properties page, by selecting the
'Obsoleted' state.
* The $allow_delete config variable has been removed. If topic
deletion is to be enabled, the 'Deleted' state needs to be added to
the @topic_states configuration variable in codestriker.conf.
* Added new configuration variable @Codestriker::exclude_file_types
which contains a list of filename extensions which Codestriker will
ignore when creating topics. These generally include those
extensions which are binary, or of not any interest. Contributed by
Dave Clendenan <dave.clendenan@polycom.com>.
* Added a checkbox "Default to HEAD" on the create topic screen which
is used for topics based off tags. If this checkbox is enabled, the
'-f' flag is passed to CVS repositories when executing the 'cvs
rdiff' command. This has the effect of retrieving a file's contents
from revision HEAD if it is not present for the specified tag value.
This option currently has no effect for other repository types at
this stage. Contributed by Dave Clendenan.
* Minor fix for handing CVS rdiff text which end in a binary entry.
Problem found by Dave Clendenan.
* Shorten the URLs sent in the email messages.
* Minor fix where " characters would not render correctly in the
status bar or in a tool-tip when hovering over a commented line in
the view topic window.
The following changes are from Jason Remillard:
* Fixed a security problem with the repository not being checked
against the actual configured list. A user could send in any well
formed repository string and Codestriker would just take it, even if
it was not configured.
* Fixed a bug preventing create topic from working when the user had
just one repository working. The cookie was overriding it because it
was missing from the html code.
* Subversion repositories can now be configured with a username and
password in the configuration file if authentication is required.
Any errors from accessing subversion are written to STDERR.
Version 1.8.4
* The topic properties page now displays the start tag, end tag and
module parameters if they were used when the topic was created.
Contribution by Robert Hudson <codestriker@go2town.co.uk>.
* The repository property has been changed to be a read-only property
in the topic properties page, from Robert Hudson.
* The repository selection drop-down is only selected if there is more
than one repository configured in the system, from Robert Hudson.
* If a topic is not in open state, then the "topic information" and
"topic comments" pages are modified to readonly, and adding new
comments is disabled. From Robert Hudson.
* In the table of contents, display the total number of lines added
and removed for each file. This gives the reviewer a quick idea
where the major changes in the review are. From Robert Hudson.
* There is a new configuration option @project_states which controls
whether a project can have its state changed to 'Closed',
which prevents new topics being created within it, and the state
'Deleted', which will delete the project and all its member topics.
Both of these new states are optional, and are not available by
default. From Robert Hudson.
* When sending emails involving more than one CC recipient, the email
sending may fail because a space wasn't put after each comma.
* Created the CodestrikerClient module in bin which can create a
new topic non-interactively. The intention is for this module to be
used from scripts that need to create new topics, for example, from
a CVS post-commit script.
* Modified custom CVS post-commit scripts so that a Codestriker topic
is created for each CVS commit, along with a sent email. The
commit_prep.pl and log_accum.pl are located in the bin directory,
and need to be copied into your CVSROOT area, with a line like the
following in your commitinfo file:
DEFAULT $CVSROOT/CVSROOT/commit_prep.pl -r
and a line like the following in your loginfo file:
DEFAULT $CVSROOT/CVSROOT/log_accum.pl %s
The log_accum.pl file needs to have some configuration variables set
at the start of the script to reflect your site.
Note the first line of the log message will be used as the topic
title. The entire log message is used as the topic description.
Any strings of the form "Bug nnn" in the log message will be taken
as a reference to a bug id, and will be used in the topic's bugid
field.
* Added an optional show_on_mainpage attribute to the comment metrics
configuration, which specifies which comment metric counts will
appear on the topic list page. From Jason Remillard.
* Reviewers who haven't viewed a topic will have their names
surrounded by parenthesis in the topic list page. From Jason
Remillard.
* Fixed a number of taint-mode problems when using Perl 5.8.
* Fixed the "Attempt to bless into a reference" error when using
Bugzilla integration and Perl 5.8.
* Migrated the MySQL datetime type from TIMESTAMP to DATETIME, as it
should have always been. From Jason Remillard.
Version 1.8.3
* It is now possible to specify multiple metrics associated with a
comment "thread". In previous versions of Codestriker, there was a
configuration variable called @comment_states which had the default
values of "Submitted", "Invalid", or "Completed". These states
still exist, but under the metric name "Status" by default.
Some other example configurations are illustrated in the config
file. For example "Level", "Mode" and "Type" metrics. These values
are then accumulated in the "Topic Information" tab, along with all
the other topic metrics.
Apart from the add/edit comment screen, the topic comments screen
allows you to modify any metric associated with any comment thread,
via a series of dropdown form elements.
* It is now possible in the create topic screen to only specify a
single tag and a module name in order to create a new topic, rather
than both the start and end tags, with the module name. The effect
of a single tag is to create a topic with the full contents of all
tagged files in the specified module.
* In the "Topic Properties" screen, if the Bug IDs field is being
displayed, and $Codestriker::bugtracker is defined, then after this
field will be a number of hyperlinks to the associated bug tracking
records.
* Added the link "List open topics in project" to all the view topic
screens for user convenience on large multi-project deployments.
* Refactored CvsPserver and CvsLocal into a single object, Cvs.
* It is now possible to specify CVS repositories using the :ext access
method with ssh, providing that the user running the Codestriker web
application can ssh into the specified host without requiring a
password (ie setting up an authorized_keys file on the destination
host). The Codestriker configuration file has an example :ext
repository, and requires the path to ssh to be specified in the $ssh
setting.
* Fixed bug where a comment with a " character in it would cause
Javascript errors with IE on the view topic page.
* In the add comment window, clicking on the "increase context" or
"decrease context" would erase any text which had been written.
This has now been fixed by Kannan Goundan.
* Increasing/decreasing the context from the add comment window would
not focus the main browser window to the exact line the comment was
made from, after the comment has been submitted. This has now been
fixed.
* Committed in a whole heap of test scripts from Jason Remillard
which are located in the test/ subdirectory.
* The clearcase diff parser can now handle diffs which describe chunk
movements such as:
-----[deleted/moved 40 after 44 (now at 152)]-----
-----[deleted/moved 42-43 after 44 (now at 154-155)]-----
-----[after 135 inserted/moved 152 (was at 40)]-----
-----[after 135 inserted/moved 154-155 (was at 42-43)]-----
* Perforce integration has been improved to work with older versions
of p4.
* The subversion diff parser can now handle diffs which contain
property set changes.
* Make sure topics are linked to the default hidden project when
$allow_projects is set to 0. This allows the "topic properties"
screen to work correctly.
Version 1.8.2
* Codestriker now has the ability to view a specific file at a time in
the view topic screen, with previous/next file links. The old
behaviour of viewing the entire topic text in one page is still the
default behaviour. The default behaviour can be changed by setting
the $default_file_to_view variable in the configuration file. Note
there are now links on the view topic screen so the user can choose
dynamically which viewing mode they would prefer to use.
Contribution by Oliver Lohmann <oliver_lohmann@gmx.de>.
* Codestriker can now sort by the column headers in the topic list
view, from Jason Remillard.
* It is now possible to create Subversion topics by entering values
in the START_TAG, END_TAG and MODULE fields on the create topic
page, from Jason Remillard. See the manual for more details.
* In addition to the existing Subversion HTTP server support, it is
now possible to integrate with a native Subversion server as well,
from Jason Remillard.
* Codestriker can now parse basic diff files (non unidiff and context
diff), and also ClearCase serial diffs.
* A ClearCase repository object has been written by Kannan Goundan
which works off a snapshot view. With the ClearCase serial diff
parser mentioned in the previous item, this provides a
fully-functional ClearCase code-reviewing solution.
* Topic property change emails didn't have the "References" and
"In-Reply-To" mail headers set correctly, so that those emails
weren't grouped into the same "topic" email thread.
* The view topic display has been improved for diffs which contain new
files. Now the entire width of the screen is used when displaying
new files. Fix from Jason Remillard and Kannan Goundan.
* The email taint/input checking code has been tightened, from Jason
Remillard.
* Improved the input checking code on the topic properties page.
* The CVS pserver repository specification has been expanded so that
it can accept extra optional arguments, such as:
:pserver;proxy=abc.com;proxyport=8080:user:pwd@cvs.dev.net
* Modified Codestriker CSS so that monospace fonts use "monospace"
rather than Courier so the user's settings in the browser are
honoured, from Kannan Goundan <kannan@letterboxes.org>.
* Standardised all inline help links to (?) rather than
(What's this?).
* Make sure filenames are properly quoted in the CVS repository
methods, so that filenames with spaces are handled correctly.
Version 1.8.1
* Modified the filename field in the topicfile table back to 255
characters instead of 1024 so that MySQL doesn't complain.
* Added some missing imports which caused compilation errors for
Perl 5.8.3 on Solaris when checksetup.pl was run.
* Made checksetup.pl more graceful when DBI.pm is not installed, and
it is checking what other database modules are required.
* Fixed bug found by Philipp Frauenfelder where LXR integration was
not working when the LXR database was password protected.
The following changes were from Jason Remillard:
* Fixed bug in the metric support has been fixed, which prevented the
metric data from being usable if more than one reviewer was present.
* Fixed bug where the wrong Codestriker time number was reported in
the metric summary page.
* Emails sent from topic property changes now include more information
such as what specific properties were changes. Topic creation
emails also include the list of files which have been changed.
Version 1.8.0
* Initial support for Perforce integration. Can handle topic text
from a Perforce describe command, such as:
"p4 describe -du <changenumber>" or "p4 diff -du".
* Codestriker now works under IIS as well as Apache. Use IPC::Open3
rather than IPC::Run (which doesn't work under IIS) within the
CvsLocal and CvsPserver modules when fetching remote diff data from
CVS. IPC::Run is no longer used.
* A new configuration variable $tmpdir is in codestriker.conf for
unusual setups which can't use the system default temporary
directory for the creation of temporary files. Win32 systems are
the usual culprit.
* The CVS rdiff parser didn't correctly handle new files within the
diff on Win32 platforms.
* Add more win32 example configuration to codestriker.conf.
* Include the relevant DBD modules in the checksetup.pl dependency
list, depending on what database system has been configured.
* Some minor fixes to fully support Win32-based CVS repositories,
including use of the older-style :local:c:\\cvsrep syntax. Also be
more robust in handling directory separators as either forward or
backward slashes, since different versions of CVSNT support this.
Make sure the CVS executable path is quoted, since it will often
contain spaces for Win32 environments.
* Improved useability of messages (when Perl modules are missing) for
Win32 users.
* Now support ODBC and Oracle databases. The Database
creation/upgrade code has been modified so that it is properly
modularised, and so checksetup.pl is far more maintainable. Adding
support for new Databases will now be a snap. The file table had to
be renamed to topicfile, and comment to commentdata to avoid
reserved word clashes in ODBC and Oracle.
* Added in a new topic listener which records all changes to a
comment's state, property changes to a topic and when a topic has
been viewed. Three new database tables have been added to store this
information, which can be accessed from the metrics tab of a topic.
* Added in the ability for the topic's properties to be changed,
including the title, author, bug ids, reviewers, cc, repository,
project, description and state. Updated the topic listeners to now
take the old and new topic objects as arguments.
* Introduction of per-user and per-topic metrics functionality from
Jason Remillard. In the process, the UI has been changed, plus
some general refactoring. It is possible to generate reports
based on these metrics over a collection of topics and time,
to give some indications on the effectiveness of code reviewing.
* The $Codestriker::allow_repository configuration variable is removed
since this boolean value can be derived from the length of the
@valid_repositories list. From Jason Remillard.
* Use tempfile() in Parser.pm to close a potential security hole, from
Jason Remillard.
* The topic search screen has been reworked to contain "What's this?"
links to make the individual search fields clearer. Also, allowed
the use of wildcards with the Author, Reviewer and Cc search fields.
Version 1.7.8
* If a badly-formatted repository value from codestriker.conf is used
when creating a topic, report this in a user-friendly manner.
* Report an error if a new topic to be created specifies both the
uploaded file and topic tag fields.
* Fixed bug where selecting multiple states in the search screen
reported an input error.
* HTML escaping for the topic title on the topic confirmation screen,
project information on the projects screens were not working
correctly. Most HTML escaping are now performed within the
templates directly using the html_entity filter.
* In some cases when displaying comment or topic description text,
hyperlinks were not automagically being created. If the text
contains a URL such as http://zot.com, it needs to be rendered for
convenience as <A HREF="http://zot.com">http://zot.com</A>. In
addition, if the text contains a pattern like [Bb]ug \d+ (ie Bug
122), this will be hyperlinked to the appropriate URL of the
bugtracking system, if one has been specified in the Codestriker
configuration.
* In the view comments screen with context displayed, very long topic
lines would push the "filename:linenumber", "Parallel" and "Add
Comment" links way off to the far right of the page, requiring
horizontal scrolling to see them. Rework the display so that they
are always pushed to the left, regardless of the length of the topic
lines.
* Added "Check All"/"Clear All" links in the view comments page for
convenience.
* If there is an error in sending an email, make sure a descriptive
error message is displayed. Thanks to Jason Remillard
<jremillardshop@yahoo.com> for spotting this.
Version 1.7.7
* The table of contents links on the view topic page didn't include
the brmode parameter, so clicking on a filename link reloaded the
whole topic page, which is inconvenient. This reloading behaviour
has also been fixed when coming from the topic list or create topic
page.
Version 1.7.6
* Fixed bug where created topics for deployments which had projects
disabled were not handled correctly.
* Fixed bug found by Jason Remillard <jremillardshop@yahoo.com> where
emails were being sent for those lines which already had a comment,
but $allow_comment_email was false.
Version 1.7.5
* Added in support for parsing VSS diffs, and retrieving file data
from a VSS repository. VSS support is not complete yet, as the
script for generated the diff text has not been submitted yet.
The following changes below were from Aaron Kardell