-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wish: disabling check (by special formatted comment?) #240
Comments
I don't understand the message. It is a fact that |
Right now D-Scanner doesn't do any semantic analysis, so it assumes that when you're doing |
This reminds me of that weird discussion on the NG about what types are better: signed or unsigned. |
There's a reason that this is a warning and not an error. The purpose of this check is to have people check their code for the possibility of integer underflow. In several cases it gives false positive results. |
Call me stubborn, but I don't see how we will work with a warning that triggers on 97% false positives. The ratio of "human error likeliness" / "false positive probability" needs to be a lot higher. What do we do about the code that triggers this warning after we verified its correctness? Usually you'd add a comment that disables the warning in this location or fix the code. But I don't see how this can be fixed and cluttering code with pragmas for something as trivial as taking a fixed negative offset from a length seems overkill. |
You can turn this warning off. |
Will do. :) |
any updates on this? i would also like a way to turn off a warning for single lines only. |
But I am sure that at this point .length > 0 (by assert/enforce) and it will be cool if this check on this line can be disabled by any way
The text was updated successfully, but these errors were encountered: