Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 90eca1f

Browse files
authored
Merge pull request #2960 from rainers/gc_tests_not_run
GC tests: recoverfree and nocollect should not run unittests but main merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
2 parents e018a72 + 6d8c375 commit 90eca1f

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

test/gc/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ $(ROOT)/startbackgc: startbackgc.d
5151
$(DMD) $(UDFLAGS) -of$@ sigmaskgc.d
5252

5353
$(ROOT)/recoverfree: recoverfree.d
54-
$(DMD) $(UDFLAGS) -of$@ recoverfree.d
54+
$(DMD) $(DFLAGS) -of$@ recoverfree.d
5555

5656
$(ROOT)/nocollect: nocollect.d
57-
$(DMD) $(UDFLAGS) -of$@ nocollect.d
57+
$(DMD) $(DFLAGS) -of$@ nocollect.d
5858

5959
clean:
6060
rm -rf $(ROOT)

test/gc/win64.mak

+14-12
Original file line numberDiff line numberDiff line change
@@ -6,51 +6,53 @@ DRUNTIMELIB=druntime64.lib
66

77
SRC_GC = src/gc/impl/conservative/gc.d
88
SRC = $(SRC_GC) src/rt/lifetime.d src/object.d
9-
UDFLAGS = -m$(MODEL) -g -unittest -version=CoreUnittest -conf= -Isrc -defaultlib=$(DRUNTIMELIB)
9+
_DFLAGS = -m$(MODEL) -g -conf= -Isrc -defaultlib=$(DRUNTIMELIB)
10+
UDFLAGS = $(_DFLAGS) -unittest -version=CoreUnittest
11+
RM = del
1012

1113
test: sentinel printf memstomp invariant logging precise precisegc recoverfree nocollect
1214

1315
sentinel:
1416
$(DMD) -debug=SENTINEL $(UDFLAGS) -main -of$@.exe $(SRC)
1517
.\$@.exe
16-
del $@.exe $@.obj $@.ilk $@.pdb
18+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
1719

1820
printf:
1921
$(DMD) -debug=PRINTF -debug=PRINTF_TO_FILE -debug=COLLECT_PRINTF $(UDFLAGS) -main -of$@.exe $(SRC_GC)
2022
.\$@.exe
21-
del $@.exe $@.obj $@.ilk $@.pdb gcx.log
23+
$(RM) $@.exe $@.obj $@.ilk $@.pdb gcx.log
2224

2325
memstomp:
2426
$(DMD) -debug=MEMSTOMP $(UDFLAGS) -main -of$@.exe $(SRC)
2527
.\$@.exe
26-
del $@.exe $@.obj $@.ilk $@.pdb
28+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
2729

2830
invariant:
2931
$(DMD) -debug -debug=INVARIANT -debug=PTRCHECK -debug=PTRCHECK2 $(UDFLAGS) -main -of$@.exe $(SRC)
3032
.\$@.exe
31-
del $@.exe $@.obj $@.ilk $@.pdb
33+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
3234

3335
logging:
3436
$(DMD) -debug=LOGGING $(UDFLAGS) -of$@.exe -main $(SRC)
3537
.\$@.exe
36-
del $@.exe $@.obj $@.ilk $@.pdb
38+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
3739

3840
precise:
3941
$(DMD) -debug -debug=INVARIANT -debug=MEMSTOMP $(UDFLAGS) -main -of$@.exe $(SRC)
4042
.\$@.exe --DRT-gcopt=gc:precise
41-
del $@.exe $@.obj $@.ilk $@.pdb
43+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
4244

4345
precisegc:
4446
$(DMD) $(UDFLAGS) -of$@.exe -gx $(SRC) test/gc/precisegc.d
4547
.\$@.exe
46-
del $@.exe $@.obj $@.ilk $@.pdb
48+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
4749

4850
recoverfree:
49-
$(DMD) $(UDFLAGS) -of$@.exe -gx $(SRC) test/gc/recoverfree.d
51+
$(DMD) $(_DFLAGS) -of$@.exe -gx test/gc/recoverfree.d
5052
.\$@.exe
51-
del $@.exe $@.obj $@.ilk $@.pdb
53+
$(RM) $@.exe $@.obj $@.ilk $@.pdb
5254

5355
nocollect:
54-
$(DMD) $(UDFLAGS) -of$@.exe -gx $(SRC) test/gc/nocollect.d
56+
$(DMD) $(_DFLAGS) -of$@.exe -gx test/gc/nocollect.d
5557
.\$@.exe
56-
del $@.exe $@.obj $@.ilk $@.pdb
58+
$(RM) $@.exe $@.obj $@.ilk $@.pdb

0 commit comments

Comments
 (0)