Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to use opts.file rather than opts.data #324

Closed
danreeves opened this issue Aug 14, 2015 · 2 comments
Closed

An option to use opts.file rather than opts.data #324

danreeves opened this issue Aug 14, 2015 · 2 comments

Comments

@danreeves
Copy link

It appears custom imports don't currently play nicely with opts.data, and it doesn't pass the correct values to the importer. It works fine with opts.file however.

It didn't like this option was already there. Any way to do this or any reason it shouldn't be there?

e.g.
With the code:

return gulp.src(sassGlob)
.pipe(sass({
    importer: function (url, prev, done) {
        console.log(url, prev, done)
    }
}))

It should output

// url: modules/* 
// prev: /path/to/your/assets/css/main.scss 
// done: function done(data) {
//        bridge.success(data);
//       }

but it outputs:

// url: modules/* 
// prev: stdin 
// done: function done(data) {
//        bridge.success(data);
//       }
@danreeves
Copy link
Author

danreeves@4233840 is a working fix with all tests passing. Let me know what you think.

@xzyfer
Copy link
Collaborator

xzyfer commented Dec 27, 2015

Addressed by #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants