feat: lvm storage pool impl #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmacvicar
added
the
Important (Wanted)
|
I want to merge this one, but I'd like to move 'source_devices I will try to get it done on main, and then I will rebase this one, if you don't mind. |
dmacvicar
reviewed
Sep 27, 2024
dmacvicar
force-pushed
the
lvm
branch
2 times, most recently
from
fd7ac21 to
e740d6f
Compare
dmacvicar
reviewed
Sep 28, 2024
Co-authored-by: dpap <daniel.pap@qualysoft.com>
- add proper source and target so we can add more pool implementations later - handle deprecation of top level path properly - less checks, lets libvirt handle it - add acceptance tests - refactor the test helper block device creation out of domain - add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamped #814.