-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PEG.js's Git repository a valid npm pacakge #32
Comments
Apparently Browserify works differently than I thought, so I'd need another tool or write something myself. Moving to post-1.0 milestone, but I'll accept patches for this anytime. My idea in general is that PEG.js would be a collection of regular Node.js modules (each file in The tricky point here is avoiding duplication when some module would be required from multiple places. This would be a case with |
PEG.js source code becomes a set of Node.js modules that include each other as needed. The distribution version is built by bundling these modules together, wrapping them inside a bit of boilerplate code that makes |module.exports| and |require| work. Part of a fix for GH-32.
Includes: * Moving the source code from /src to /lib. * Adding an explicit file list to package.json * Updating the Makefile. * Updating the spec and benchmark suites and their READMEs. Part of a fix for GH-32.
This is fixed now, closing. |
PEG.js's Git repository should be a valid npm pacakge, so that development versions can be installed more easily using just the following commands:
Right now attempt to run these commands ends up with npm error:
Two things will need to happen to resolve this issue:
require
in Node.js environment. For browser environment, the files will still need to be assembled into one, but this is probably doable using Browserify or some similar tool.@VERSION
substitution should be eliminated at least from thepacakge.json
file. This will lead to small duplication of the current version value, but this is lesser evil than making installation of PEG.js development versions easier.The text was updated successfully, but these errors were encountered: