Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: meta combos are not being unregistered #133

Closed
bichotll opened this issue Jan 6, 2017 · 3 comments
Closed

bug: meta combos are not being unregistered #133

bichotll opened this issue Jan 6, 2017 · 3 comments
Labels

Comments

@bichotll
Copy link

bichotll commented Jan 6, 2017

Hi, I came across with an annoying bug. Shortcuts with "meta" can not be unregistered.
At first I thought it was a problem with my script :/

In any case, I've created a demo so you can reproduce it:
http://jsbin.com/xajipev/edit?html,js,console,output
On it you can register/unregister 2 meta/ctrl shortcuts and compare the result/behaviour with the console.

I will review it myself if I have any time...

@dmauro dmauro added the bug label Mar 20, 2017
@mhuebert
Copy link

mhuebert commented Oct 12, 2017

I want to include Keypress in a little comparison between different keybindings libraries I'm making: https://keys-test.lark.cloud/?library=Combokeys&keystring=M1%2520s

but I can't include it because of this bug, it interferes with the other libs when you can't unbind things.

@mhuebert
Copy link

I have created PR #137 to fix this issue.

@dmauro
Copy link
Owner

dmauro commented Mar 5, 2018

Will be fixed in the .5 release

@dmauro dmauro closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants