Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourcesApprovalsExtension change from v1 to v2 #14

Open
naridas opened this issue Feb 23, 2024 · 0 comments
Open

ResourcesApprovalsExtension change from v1 to v2 #14

naridas opened this issue Feb 23, 2024 · 0 comments

Comments

@naridas
Copy link

naridas commented Feb 23, 2024

So when moving to v2 we were using ResourcesApprovalsExtension for v1 to set the source dir but it broke because it changed to adding src/test/resources to the end of the file instead of going to that directory so we fixed by doing this:

class Test { 
private val sourceRoot: File = File("src/test/resources")

    @RegisterExtension
    val approvals: ApprovalsExtension = ApprovalsExtension(sourceRoot)
    ...

previously we were doing this:

@ExtendWith(ResourcesApprovalsExtension::class)
class Test { 
...

is this a bug or not or were we miss using it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant