Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approver cannot approve empty output #6

Open
anuratransfers opened this issue May 10, 2017 · 0 comments
Open

Approver cannot approve empty output #6

anuratransfers opened this issue May 10, 2017 · 0 comments

Comments

@anuratransfers
Copy link

For example, given the code:

@Rule @JvmField val approver = ApprovalsRule.usualRule()!!

@Test fun reads_excluded_journal_ids_from_resources() {
    val contexts = HiddenContexts()
    val stableSet = contexts.journalSuggesterExcludedJournalIds.map { Integer.parseInt(it) }.toSortedSet()
    approver.assertApproved(stableSet.joinToString("\n"))
}

Empty stableSet can never be approved because internally LazyOutputStream will not create .actual file and will compare empty stableSet to null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant