Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signERC2612Permit not working on Ganache/Buidler #2

Closed
gorgos opened this issue Oct 4, 2020 · 2 comments
Closed

signERC2612Permit not working on Ganache/Buidler #2

gorgos opened this issue Oct 4, 2020 · 2 comments

Comments

@gorgos
Copy link

gorgos commented Oct 4, 2020

@dmihal I tried to fix it and the following changes made it work:

  1. Change

    const result = await send(provider, 'eth_signTypedData_v4', [fromAddress, _typeData]);
    to const result = await send(provider, 'eth_signTypedData', [fromAddress, JSON.parse(_typeData)]); (two changes)

  2. Add jsonrpc: '2.0', to

    const payload = {
    .

Do you have any insights on this?

@ghardin1314
Copy link

Apparently metamask knows about this and a fix is shipped. Already working on firefox and will be working on chrome next week. Discussed here

@dmihal
Copy link
Owner

dmihal commented Nov 1, 2020

The new version tries eth_signTypedData_v4 & eth_signTypedData

Let me know if anyone's still having issues

@dmihal dmihal closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants