Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

apply_weight_drop required changes to integrate mxnet 1.3 #264

Closed
3 tasks
szha opened this issue Aug 10, 2018 · 0 comments · Fixed by #268
Closed
3 tasks

apply_weight_drop required changes to integrate mxnet 1.3 #264

szha opened this issue Aug 10, 2018 · 0 comments · Fixed by #268
Assignees
Labels
bug Something isn't working release focus Progress focus for release

Comments

@szha
Copy link
Member

szha commented Aug 10, 2018

our existing implementation on apply_weight_drop relied on a non-public attribute in gluon RNN blocks that were removed apache/mxnet#11482 when making the RNN blocks hybrid, and it does not have test, which will prevent us from integrating with mxnet 1.3. We need:

  • fix apply_weight_drop and upgrade the mxnet dependency to allow 1.3 integration.
  • add test for apply_weight_drop
  • bump up minor version to 0.4 which relies on 1.3.
@szha szha added API change release focus Progress focus for release labels Aug 10, 2018
@szha szha self-assigned this Aug 10, 2018
@szha szha added bug Something isn't working and removed API change labels Aug 10, 2018
@szha szha closed this as completed in #268 Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release focus Progress focus for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant